Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix default layout state #3392

Merged
merged 5 commits into from
Mar 12, 2024
Merged

fix: fix default layout state #3392

merged 5 commits into from
Mar 12, 2024

Conversation

erha19
Copy link
Member

@erha19 erha19 commented Mar 11, 2024

Types

  • 🐛 Bug Fixes

Background or solution

close #3365

Changelog

fix default layout config

@erha19 erha19 requested review from bytemain and Ricbet March 11, 2024 06:39
Copy link

railway-app bot commented Mar 11, 2024

This PR is being deployed to Railway 🚅

core: ◻️ REMOVED

@opensumi opensumi bot added the 🐞 bug Something isn't working label Mar 11, 2024
bytemain
bytemain previously approved these changes Mar 11, 2024
@erha19 erha19 changed the title fix: fix default layout state WIP: fix: fix default layout state Mar 11, 2024
Copy link

codecov bot commented Mar 11, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 57.99%. Comparing base (f9865d0) to head (310855b).
Report is 1 commits behind head on main.

Files Patch % Lines
...s/main-layout/src/browser/tabbar/tabbar.service.ts 75.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3392      +/-   ##
==========================================
- Coverage   58.07%   57.99%   -0.08%     
==========================================
  Files        1413     1413              
  Lines       86804    86828      +24     
  Branches    17917    17924       +7     
==========================================
- Hits        50408    50358      -50     
- Misses      33108    33174      +66     
- Partials     3288     3296       +8     
Flag Coverage Δ
jsdom 53.14% <83.33%> (+0.21%) ⬆️
node 16.25% <0.00%> (-1.59%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@erha19 erha19 changed the title WIP: fix: fix default layout state fix: fix default layout state Mar 12, 2024
@erha19
Copy link
Member Author

erha19 commented Mar 12, 2024

@bytemain 这里的 tabbarService.viewReady 不是删了,而是放到了 updatePanelSize 和 updateBarSize 内处理了,用 panelSize 和 barSize 同时有值来判断视图 Ready

@bytemain
Copy link
Member

ok,那也处理一下这个没有 componentInfos 的情况:
CleanShot 2024-03-12 at 11 26 29@2x

@erha19
Copy link
Member Author

erha19 commented Mar 12, 2024

close #3364

@erha19 erha19 linked an issue Mar 12, 2024 that may be closed by this pull request
@erha19 erha19 merged commit f2c51b4 into main Mar 12, 2024
12 checks passed
@erha19 erha19 deleted the fix/main-layout-store branch March 12, 2024 06:29
@erha19 erha19 added the v3 OpenSumi 3.0 label Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working v3 OpenSumi 3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] 关闭 tabbar 视图时刷新页面会撑开一片空白布局 [BUG] 右侧视图面板无法展开
2 participants