Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support configure collaboration server opts #3399

Merged
merged 2 commits into from
Mar 19, 2024

Conversation

bytemain
Copy link
Member

@bytemain bytemain commented Mar 13, 2024

Types

  • 🎉 New Features

Background or solution

之前无法配置 y-websocket server 监听的端口

close: #2405

Changelog

support configure collaboration server opts

Copy link

railway-app bot commented Mar 13, 2024

This PR is being deployed to Railway 🚅

core: ◻️ REMOVED

@opensumi opensumi bot added the 🎨 feature feature required label Mar 13, 2024
Ricbet
Ricbet previously approved these changes Mar 13, 2024
Copy link

codecov bot commented Mar 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.99%. Comparing base (466204f) to head (fadf979).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3399   +/-   ##
=======================================
  Coverage   57.98%   57.99%           
=======================================
  Files        1413     1413           
  Lines       86828    86830    +2     
  Branches    17924    17926    +2     
=======================================
+ Hits        50351    50353    +2     
  Misses      33180    33180           
  Partials     3297     3297           
Flag Coverage Δ
jsdom 53.13% <100.00%> (+<0.01%) ⬆️
node 16.25% <66.66%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bytemain bytemain requested a review from Ricbet March 14, 2024 03:17
@bytemain bytemain merged commit 40534d5 into main Mar 19, 2024
13 checks passed
@bytemain bytemain deleted the feat/collaborationServer branch March 19, 2024 05:52
@erha19 erha19 added the v3 OpenSumi 3.0 label Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 feature feature required v3 OpenSumi 3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] 上游集成协同模块时总是提示 address already
3 participants