Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: restore layout state on web lite #3406

Merged
merged 3 commits into from
Mar 18, 2024
Merged

Conversation

erha19
Copy link
Member

@erha19 erha19 commented Mar 15, 2024

Types

  • 🐛 Bug Fixes

Background or solution

原有的修改会导致纯前端环境下渲染时序问题,让 viewReady 提前 resolve

Changelog

fix restore layout state on web lite

@opensumi opensumi bot added the 🐞 bug Something isn't working label Mar 15, 2024
@erha19 erha19 requested a review from bytemain March 15, 2024 07:50
Copy link

codecov bot commented Mar 15, 2024

Codecov Report

Attention: Patch coverage is 58.82353% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 57.41%. Comparing base (0cc59cd) to head (2630351).

Files Patch % Lines
...s/main-layout/src/browser/tabbar/tabbar.service.ts 58.33% 5 Missing ⚠️
packages/output/src/browser/output.service.ts 60.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3406      +/-   ##
==========================================
+ Coverage   57.39%   57.41%   +0.02%     
==========================================
  Files        1433     1433              
  Lines       88195    88203       +8     
  Branches    18154    18156       +2     
==========================================
+ Hits        50618    50646      +28     
+ Misses      34182    34168      -14     
+ Partials     3395     3389       -6     
Flag Coverage Δ
jsdom 52.64% <58.82%> (+0.02%) ⬆️
node 16.07% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bytemain bytemain merged commit 10ec45f into main Mar 18, 2024
11 checks passed
@bytemain bytemain deleted the fix/layout-state-failed branch March 18, 2024 03:24
@erha19 erha19 added the v3 OpenSumi 3.0 label Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working v3 OpenSumi 3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants