Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement Tab APIs #3413

Merged
merged 1 commit into from
Apr 10, 2024
Merged

feat: implement Tab APIs #3413

merged 1 commit into from
Apr 10, 2024

Conversation

MMhunter
Copy link
Contributor

@MMhunter MMhunter commented Mar 18, 2024

Types

  • 🎉 New Features

Background or solution

implements extension Tab APIs to #3227

Changelog

implements extension Tab APIs

Copy link

codecov bot commented Mar 18, 2024

Codecov Report

Attention: Patch coverage is 11.58537% with 435 lines in your changes are missing coverage. Please review.

Project coverage is 56.66%. Comparing base (0cc59cd) to head (00abc4a).
Report is 42 commits behind head on main.

Files Patch % Lines
...sion/src/hosted/api/vscode/ext.host.editor-tabs.ts 4.07% 212 Missing ⚠️
.../src/browser/vscode/api/main.thread.editor-tabs.ts 3.27% 177 Missing ⚠️
packages/webview/src/browser/webview.service.ts 20.00% 12 Missing ⚠️
...ges/editor/src/browser/workbench-editor.service.ts 71.79% 11 Missing ⚠️
packages/extension/src/common/vscode/ext-types.ts 50.00% 9 Missing ⚠️
packages/utils/src/functional.ts 10.00% 9 Missing ⚠️
packages/utils/src/types.ts 25.00% 3 Missing ⚠️
.../src/hosted/api/vscode/ext.host.window.api.impl.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3413      +/-   ##
==========================================
- Coverage   57.39%   56.66%   -0.73%     
==========================================
  Files        1433     1461      +28     
  Lines       88195    89841    +1646     
  Branches    18154    17482     -672     
==========================================
+ Hits        50618    50912     +294     
- Misses      34182    38906    +4724     
+ Partials     3395       23    -3372     
Flag Coverage Δ
jsdom 51.96% <11.58%> (-0.66%) ⬇️
node 15.81% <2.23%> (-0.26%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MMhunter MMhunter changed the title WIP: implement Tab APIs Feat: implement Tab APIs Mar 21, 2024
@bytemain bytemain changed the title Feat: implement Tab APIs feat: implement Tab APIs Mar 21, 2024
@opensumi opensumi bot added the 🎨 feature feature required label Mar 21, 2024
@erha19 erha19 added the v3 OpenSumi 3.0 label Mar 27, 2024
@bytemain bytemain merged commit 0c8a216 into main Apr 10, 2024
10 of 11 checks passed
@bytemain bytemain deleted the feat/tab-api branch April 10, 2024 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 feature feature required v3 OpenSumi 3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants