Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove duplicate code #3419

Merged
merged 1 commit into from
Mar 20, 2024
Merged

chore: remove duplicate code #3419

merged 1 commit into from
Mar 20, 2024

Conversation

l1shen
Copy link
Contributor

@l1shen l1shen commented Mar 20, 2024

Types

fix: #3414 (review)

修改调用之后发现下面有重复的调用,所以把这个注册删除了

  • 🎉 New Features
  • 🐛 Bug Fixes
  • 📚 Documentation Changes
  • 💄 Code Style Changes
  • 💄 Style Changes
  • 🪚 Refactors
  • 🚀 Performance Improvements
  • 🏗️ Build System
  • ⏱ Tests
  • 🧹 Chores
  • Other Changes

Background or solution

Changelog

@opensumi opensumi bot added the 🐞 bug Something isn't working label Mar 20, 2024
Copy link
Member

@erha19 erha19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks~

Copy link

codecov bot commented Mar 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.16%. Comparing base (d349bb4) to head (1e42a18).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3419   +/-   ##
=======================================
  Coverage   57.16%   57.16%           
=======================================
  Files        1438     1438           
  Lines       88842    88841    -1     
  Branches    18307    18307           
=======================================
  Hits        50783    50783           
+ Misses      34626    34625    -1     
  Partials     3433     3433           
Flag Coverage Δ
jsdom 52.42% <ø> (+<0.01%) ⬆️
node 15.95% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@erha19 erha19 merged commit 3f568fb into opensumi:main Mar 20, 2024
14 checks passed
@l1shen l1shen deleted the fix-editor branch March 20, 2024 05:44
@erha19 erha19 added the v3 OpenSumi 3.0 label Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working v3 OpenSumi 3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants