Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rename widget show keycode #3429

Merged
merged 1 commit into from
Mar 21, 2024
Merged

fix: rename widget show keycode #3429

merged 1 commit into from
Mar 21, 2024

Conversation

bytemain
Copy link
Member

@bytemain bytemain commented Mar 21, 2024

Types

  • 🐛 Bug Fixes

Background or solution

close: #3089

CleanShot 2024-03-21 at 17 15 37@2x

这个原因是因为 monaco 查找 keybinding 的时候仅查找了它自己注册的那些快捷键,某些快捷键是 opensumi 绑定的,只是去调用了 monaco 相应的命令,所以比较简单的一个方案是重写一下 monaco lookup binding 的逻辑,先查内部的,再查外部的即可。

Changelog

Fix rename widget cannot show key code

@opensumi opensumi bot added the 🐞 bug Something isn't working label Mar 21, 2024
Copy link

codecov bot commented Mar 21, 2024

Codecov Report

Attention: Patch coverage is 77.77778% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 57.14%. Comparing base (426adea) to head (7d51d6d).
Report is 1 commits behind head on main.

Files Patch % Lines
packages/monaco/src/browser/monaco.service.ts 77.77% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3429      +/-   ##
==========================================
- Coverage   57.14%   57.14%   -0.01%     
==========================================
  Files        1441     1441              
  Lines       88874    88871       -3     
  Branches    18310    18309       -1     
==========================================
- Hits        50784    50782       -2     
+ Misses      34655    34654       -1     
  Partials     3435     3435              
Flag Coverage Δ
jsdom 52.40% <77.77%> (-0.01%) ⬇️
node 15.95% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bytemain bytemain merged commit 2d5aa92 into main Mar 21, 2024
12 checks passed
@bytemain bytemain deleted the fix/rename-keycode branch March 21, 2024 11:55
@erha19 erha19 added the v3 OpenSumi 3.0 label Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working v3 OpenSumi 3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] F2 快捷键「重命名符号」的 Tips 提示文案为 undefined
3 participants