Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: use design mode specific layout #3462

Merged
merged 2 commits into from
Mar 27, 2024
Merged

Conversation

erha19
Copy link
Member

@erha19 erha19 commented Mar 27, 2024

Types

  • 💄 Style Changes

Background or solution

Design 布局下使用特定的布局
image
截屏2024-03-27 16 47 47

Changelog

use design mode specify layout

Copy link

codecov bot commented Mar 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.87%. Comparing base (d69b2df) to head (6eb4399).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3462      +/-   ##
==========================================
- Coverage   56.89%   56.87%   -0.03%     
==========================================
  Files        1461     1461              
  Lines       89395    89433      +38     
  Branches    17393    18420    +1027     
==========================================
+ Hits        50864    50865       +1     
+ Misses      38508    35107    -3401     
- Partials       23     3461    +3438     
Flag Coverage Δ
jsdom 52.14% <ø> (-0.03%) ⬇️
node 15.87% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@erha19 erha19 added the v3 OpenSumi 3.0 label Mar 27, 2024
@bytemain
Copy link
Member

意思是集成方不仅要引用 DesignModule,还得手动配置这个?感觉有点麻烦了

@erha19
Copy link
Member Author

erha19 commented Mar 27, 2024

意思是集成方不仅要引用 DesignModule,还得手动配置这个?感觉有点麻烦了

我改一下,好像可以复用一下

@erha19
Copy link
Member Author

erha19 commented Mar 27, 2024

Done

@bytemain bytemain changed the title style: use design mode specify layout style: use design mode specific layout Mar 27, 2024
@bytemain bytemain merged commit 08a1f0b into main Mar 27, 2024
12 checks passed
@bytemain bytemain deleted the refactor/use-design-layout branch March 27, 2024 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants