Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dep): semver need an old version lru-cache #3496

Merged
merged 5 commits into from
Apr 8, 2024
Merged

Conversation

bytemain
Copy link
Member

@bytemain bytemain commented Apr 3, 2024

Types

  • 🏗️ Build System
  • 🧹 Chores

Background or solution

在 railway 上的 preview 跑不起来了,因为之前更新过依赖,semver 依赖的 lru-cache@6.0.0 没有被提升到正确的位置,所以跑不起来,这里直接在 package.json 中声明该版本

CleanShot 2024-04-03 at 20 06 34@2x

Changelog

Copy link

railway-app bot commented Apr 3, 2024

This PR is being deployed to Railway 🚅

core: ◻️ REMOVED

@opensumi opensumi bot added the 🐞 bug Something isn't working label Apr 3, 2024
Copy link

codecov bot commented Apr 3, 2024

Codecov Report

Attention: Patch coverage is 53.84615% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 56.84%. Comparing base (7ea550b) to head (c493e22).
Report is 1 commits behind head on main.

Files Patch % Lines
...ages/terminal-next/src/browser/terminal.service.ts 58.33% 5 Missing ⚠️
.../ai-native/src/browser/model/msg-stream-manager.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3496      +/-   ##
==========================================
- Coverage   56.84%   56.84%   -0.01%     
==========================================
  Files        1461     1461              
  Lines       89485    89481       -4     
  Branches    18418    18213     -205     
==========================================
- Hits        50865    50861       -4     
  Misses      35152    35152              
  Partials     3468     3468              
Flag Coverage Δ
jsdom 52.11% <53.84%> (-0.01%) ⬇️
node 15.88% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@erha19 erha19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bytemain bytemain merged commit e5bb8f7 into main Apr 8, 2024
12 checks passed
@bytemain bytemain deleted the fix/dep/semver branch April 8, 2024 03:51
bytemain added a commit that referenced this pull request Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants