Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: monaco keybinding registry #3504

Merged
merged 1 commit into from
Apr 9, 2024
Merged

fix: monaco keybinding registry #3504

merged 1 commit into from
Apr 9, 2024

Conversation

erha19
Copy link
Member

@erha19 erha19 commented Apr 8, 2024

Types

  • 🐛 Bug Fixes

Background or solution

修复部分 monaco 快捷键缺少 when 导致的异常触发问题

Changelog

fix monaco keybinding registry

@erha19 erha19 requested review from bytemain and Ricbet April 8, 2024 10:28
Copy link

railway-app bot commented Apr 8, 2024

This PR was not deployed automatically as @erha19 does not have access to the Railway project.

In order to get automatic PR deploys, please add @erha19 to the project inside the project settings page.

@opensumi opensumi bot added the 🐞 bug Something isn't working label Apr 8, 2024
@erha19 erha19 force-pushed the fix/monaco-keybinding-error branch from e0dd416 to 1411811 Compare April 8, 2024 10:29
@erha19
Copy link
Member Author

erha19 commented Apr 8, 2024

/next

@opensumi
Copy link
Contributor

opensumi bot commented Apr 8, 2024

🎉 PR Next publish successful!

2.27.3-next-1712572322.0

Copy link

codecov bot commented Apr 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.84%. Comparing base (c648ab4) to head (1411811).

Additional details and impacted files
@@            Coverage Diff            @@
##             main    #3504     +/-   ##
=========================================
  Coverage   56.84%   56.84%             
=========================================
  Files        1461     1461             
  Lines       89481    89481             
  Branches    18418    17404   -1014     
=========================================
+ Hits        50861    50866      +5     
+ Misses      38597    38592      -5     
  Partials       23       23             
Flag Coverage Δ
jsdom 52.11% <ø> (+<0.01%) ⬆️
node 15.88% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@erha19 erha19 merged commit d393208 into main Apr 9, 2024
12 checks passed
@erha19 erha19 deleted the fix/monaco-keybinding-error branch April 9, 2024 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants