Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: more stable layout view restore process #3530

Merged
merged 4 commits into from
Apr 15, 2024
Merged

Conversation

erha19
Copy link
Member

@erha19 erha19 commented Apr 11, 2024

Types

  • 🧹 Chores

Background or solution

Changelog

remove useless runInAction function

Copy link

railway-app bot commented Apr 11, 2024

This PR was not deployed automatically as @erha19 does not have access to the Railway project.

In order to get automatic PR deploys, please add @erha19 to the project inside the project settings page.

@erha19
Copy link
Member Author

erha19 commented Apr 11, 2024

/next

Copy link

codecov bot commented Apr 11, 2024

Codecov Report

Attention: Patch coverage is 44.11765% with 19 lines in your changes are missing coverage. Please review.

Project coverage is 56.50%. Comparing base (0babbe6) to head (11da19d).
Report is 9 commits behind head on main.

Files Patch % Lines
...s/main-layout/src/browser/tabbar/tabbar.service.ts 42.42% 19 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3530      +/-   ##
==========================================
- Coverage   56.58%   56.50%   -0.09%     
==========================================
  Files        1462     1480      +18     
  Lines       89939    90307     +368     
  Branches    18510    17545     -965     
==========================================
+ Hits        50892    51024     +132     
- Misses      39024    39260     +236     
  Partials       23       23              
Flag Coverage Δ
jsdom 51.82% <44.11%> (-0.07%) ⬇️
node 15.76% <0.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@erha19
Copy link
Member Author

erha19 commented Apr 11, 2024

/next

@opensumi
Copy link
Contributor

opensumi bot commented Apr 11, 2024

🎉 PR Next publish successful!

2.27.3-next-1712822140.0

@erha19
Copy link
Member Author

erha19 commented Apr 11, 2024

/next

@opensumi
Copy link
Contributor

opensumi bot commented Apr 11, 2024

🎉 PR Next publish successful!

2.27.3-next-1712829267.0

@erha19 erha19 changed the title chore: remove useless runInAction function WIP: chore: remove useless runInAction function Apr 12, 2024
@erha19
Copy link
Member Author

erha19 commented Apr 12, 2024

/next

@erha19 erha19 changed the title WIP: chore: remove useless runInAction function fix: more stable layout view restore process Apr 12, 2024
@opensumi opensumi bot added the 🐞 bug Something isn't working label Apr 12, 2024
@erha19
Copy link
Member Author

erha19 commented Apr 12, 2024

/next

@opensumi
Copy link
Contributor

opensumi bot commented Apr 12, 2024

🎉 PR Next publish successful!

2.27.3-next-1712908547.0

@erha19 erha19 merged commit 7ee162f into main Apr 15, 2024
13 checks passed
@erha19 erha19 deleted the fix/tabbar-view-update branch April 15, 2024 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants