Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: multiplexer rpc id can have slash #3542

Merged
merged 3 commits into from
Apr 16, 2024
Merged

fix: multiplexer rpc id can have slash #3542

merged 3 commits into from
Apr 16, 2024

Conversation

bytemain
Copy link
Member

Types

  • 🐛 Bug Fixes

Background or solution

if rpc id has a slash, rpc wouldn't work:

Error handling request extension_extend_service:kaitian.@opensumi/runner/$fetch with args  [] Error: Unknown actor extension_extend_service:kaitian.@opensumi

Changelog

@bytemain bytemain requested a review from MMhunter April 15, 2024 11:52
Copy link

railway-app bot commented Apr 15, 2024

This PR is being deployed to Railway 🚅

@opensumi opensumi bot added the 🐞 bug Something isn't working label Apr 15, 2024
Copy link

codecov bot commented Apr 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.13%. Comparing base (9ff7278) to head (6437711).
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3542      +/-   ##
==========================================
- Coverage   56.15%   56.13%   -0.02%     
==========================================
  Files        1485     1485              
  Lines       90942    90891      -51     
  Branches    17666    18644     +978     
==========================================
- Hits        51070    51026      -44     
+ Misses      39849    33059    -6790     
- Partials       23     6806    +6783     
Flag Coverage Δ
jsdom 51.50% <100.00%> (-0.01%) ⬇️
node 15.66% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Ricbet
Ricbet previously approved these changes Apr 16, 2024
@bytemain bytemain merged commit 27e3bf4 into main Apr 16, 2024
12 checks passed
@bytemain bytemain deleted the fix/rpc-multiplexer branch April 16, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants