Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support Dynamic DebugConfiguration Provider, add debug run toolbar #3557

Merged
merged 16 commits into from
Apr 19, 2024

Conversation

life2015
Copy link
Member

Types

支持了 Dynamic DebugConfiguration Provider 的插件 API,可以支持插件自定义贡献的动态配置能力。

支持了运行的 Toolbar,可以在 Toolbar 上快捷使用 运行/ Debug 能力

image image
  • 🎉 New Features

Background or solution

OpenSumi 需要给用户提供更加便捷的项目运行能力,但是 launch.json 的配置和使用方式并非完全没有门槛,对于一些不熟悉的用户可能会导致项目难以运行起来。因此需要对 debug 和运行能力做优化,让用户以尽可能低的成本将手头的项目运行起来。
本功能 PR 分两部分:

  • 项目的快捷运行需要一套能力来支持「根据项目自动生成 launch.json」 配置的能力,此能力最适合的 VSCode Extension API 就是 Dynamic DebugConfiguration Provider,因此本 PR 实现了该接口的兼容适配。
  • Debug / Run 功能更快捷的使用,调整交互,支持在 Toolbar 上配置 Debug / Run 面板,快速运行

Changelog

  • support VSCode Extension API: Dynamic DebugConfiguration Provider
  • support run Toolbar

Copy link

railway-app bot commented Apr 17, 2024

This PR was not deployed automatically as @life2015 does not have access to the Railway project.

In order to get automatic PR deploys, please add @life2015 to the project inside the project settings page.

@opensumi opensumi bot added the 🎨 feature feature required label Apr 17, 2024
Copy link

codecov bot commented Apr 19, 2024

Codecov Report

Attention: Patch coverage is 22.52747% with 141 lines in your changes are missing coverage. Please review.

Project coverage is 56.03%. Comparing base (6a7261a) to head (8c208b3).
Report is 1 commits behind head on main.

Files Patch % Lines
...s/debug/src/browser/debug-configuration-manager.ts 11.22% 65 Missing and 22 partials ⚠️
...rowser/vscode/api/debug/extension-debug-service.ts 9.37% 21 Missing and 8 partials ⚠️
.../view/configuration/debug-configuration.service.ts 55.17% 10 Missing and 3 partials ⚠️
...sion/src/hosted/api/vscode/debug/ext.host.debug.ts 0.00% 9 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3557      +/-   ##
==========================================
- Coverage   56.08%   56.03%   -0.05%     
==========================================
  Files        1488     1488              
  Lines       90994    91157     +163     
  Branches    18656    18699      +43     
==========================================
+ Hits        51038    51084      +46     
- Misses      33141    33226      +85     
- Partials     6815     6847      +32     
Flag Coverage Δ
jsdom 51.42% <22.52%> (-0.05%) ⬇️
node 15.62% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Ricbet Ricbet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Ricbet Ricbet merged commit f1bef23 into main Apr 19, 2024
11 checks passed
@Ricbet Ricbet deleted the feat/support-dynamic-config-ai branch April 19, 2024 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 feature feature required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants