Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: optimize decoration clearing logic in tree service #3573

Merged
merged 1 commit into from
Apr 23, 2024

Conversation

erha19
Copy link
Member

@erha19 erha19 commented Apr 22, 2024

Types

  • 🐛 Bug Fixes

Background or solution

解决设置面板焦点 Tree 选中态清理不完全问题

image

Changelog

optimize decoration clearing logic in tree service

@erha19 erha19 requested review from bytemain and Ricbet April 22, 2024 09:29
Copy link

railway-app bot commented Apr 22, 2024

This PR was not deployed automatically as @erha19 does not have access to the Railway project.

In order to get automatic PR deploys, please add @erha19 to the project inside the project settings page.

@opensumi opensumi bot added the 🐞 bug Something isn't working label Apr 22, 2024
Copy link

codecov bot commented Apr 22, 2024

Codecov Report

Attention: Patch coverage is 0% with 13 lines in your changes are missing coverage. Please review.

Project coverage is 56.04%. Comparing base (f69c4a2) to head (8dc8de8).

Files Patch % Lines
.../components/src/recycle-tree/basic/tree-service.ts 0.00% 13 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3573   +/-   ##
=======================================
  Coverage   56.03%   56.04%           
=======================================
  Files        1489     1489           
  Lines       91192    91195    +3     
  Branches    18697    18697           
=======================================
+ Hits        51101    51108    +7     
+ Misses      33247    33244    -3     
+ Partials     6844     6843    -1     
Flag Coverage Δ
jsdom 51.42% <0.00%> (+<0.01%) ⬆️
node 15.62% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@erha19 erha19 merged commit fec71fa into main Apr 23, 2024
12 checks passed
@erha19 erha19 deleted the fix/basic-tree-selection branch April 23, 2024 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants