Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: early preference support configure prefix #3584

Merged
merged 3 commits into from
Apr 25, 2024

Conversation

bytemain
Copy link
Member

Types

  • 🎉 New Features

Background or solution

现在有 AI 模式和非 AI 模式两种,AI 模式的主题是不一样的,所以不希望 AI 模式的主题存到 localStorage 中被非 AI 模式读取到

Changelog

Copy link

railway-app bot commented Apr 23, 2024

This PR is being deployed to Railway 🚅

core: ◻️ REMOVED

@opensumi opensumi bot added the 🎨 feature feature required label Apr 23, 2024
Copy link

codecov bot commented Apr 23, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 56.02%. Comparing base (5d54570) to head (3a78d65).
Report is 4 commits behind head on main.

Files Patch % Lines
.../core-browser/src/preferences/early-preferences.ts 91.30% 2 Missing ⚠️
packages/theme/src/common/theme.service.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3584   +/-   ##
=======================================
  Coverage   56.01%   56.02%           
=======================================
  Files        1490     1490           
  Lines       91262    91315   +53     
  Branches    18716    18736   +20     
=======================================
+ Hits        51124    51161   +37     
- Misses      33279    33293   +14     
- Partials     6859     6861    +2     
Flag Coverage Δ
jsdom 51.40% <90.00%> (+0.01%) ⬆️
node 15.65% <73.33%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bytemain bytemain changed the title feat: early preference support configure prefix WIP: feat: early preference support configure prefix Apr 24, 2024
@bytemain bytemain changed the title WIP: feat: early preference support configure prefix feat: early preference support configure prefix Apr 24, 2024
packages/theme/src/browser/theme.contribution.ts Outdated Show resolved Hide resolved
packages/utils/src/disposable.ts Outdated Show resolved Hide resolved
Copy link
Member

@hacke2 hacke2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@wangxiaojuan
Copy link
Contributor

/next

@opensumi
Copy link
Contributor

opensumi bot commented Apr 25, 2024

🎉 PR Next publish successful!

2.27.3-next-1714013027.0

@bytemain bytemain merged commit 33d87d1 into main Apr 25, 2024
13 checks passed
@bytemain bytemain deleted the feat/isolate-storage-namespace branch April 25, 2024 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 feature feature required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants