Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(styles): fix design module style issues #3586

Merged
merged 38 commits into from
Apr 29, 2024
Merged

Conversation

bytemain
Copy link
Member

@bytemain bytemain commented Apr 24, 2024

Types

  • 🐛 Bug Fixes
  • 💄 Style Changes

Background or solution

close: #3562

  1. 解耦和 design 模块和 ai-native 模块有关 layout 的地方
  2. design 模块右上角支持注册 component
  3. e2e 模式使用默认 layout

样式优化:

  1. 鼠标悬浮到 scrollbar 上自动变成 width: 10px
  2. 加速插件 apply style sheet

Changelog

Copy link

railway-app bot commented Apr 24, 2024

This PR is being deployed to Railway 🚅

core: ◻️ REMOVED

@opensumi opensumi bot added 🐞 bug Something isn't working 💄 style change labels Apr 24, 2024
Copy link

codecov bot commented Apr 24, 2024

Codecov Report

Attention: Patch coverage is 55.86854% with 94 lines in your changes are missing coverage. Please review.

Project coverage is 56.01%. Comparing base (a46c90a) to head (2e0a1ae).
Report is 2 commits behind head on main.

Files Patch % Lines
...s/ai-native/src/browser/light-bulb-widget/index.ts 0.00% 21 Missing and 6 partials ⚠️
packages/theme/src/browser/style.service.ts 9.52% 17 Missing and 2 partials ⚠️
packages/core-browser/src/layout/constants.ts 57.14% 12 Missing and 3 partials ⚠️
...es/editor/src/browser/editor.decoration.service.ts 76.47% 8 Missing ⚠️
packages/core-browser/src/dom/event.ts 16.66% 4 Missing and 1 partial ⚠️
...ages/ai-native/src/browser/layout/layout-config.ts 0.00% 4 Missing ⚠️
...collaboration/src/browser/collaboration.service.ts 33.33% 4 Missing ⚠️
...ackages/design/src/browser/layout/layout-config.ts 0.00% 3 Missing ⚠️
packages/design/src/browser/index.ts 0.00% 2 Missing ⚠️
packages/theme/src/common/css-var.ts 86.66% 2 Missing ⚠️
... and 5 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3586      +/-   ##
==========================================
- Coverage   56.01%   56.01%   -0.01%     
==========================================
  Files        1490     1503      +13     
  Lines       91318    91459     +141     
  Branches    18736    18747      +11     
==========================================
+ Hits        51152    51228      +76     
- Misses      33305    33360      +55     
- Partials     6861     6871      +10     
Flag Coverage Δ
jsdom 51.42% <55.86%> (+<0.01%) ⬆️
node 15.64% <21.12%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Ricbet
Ricbet previously approved these changes Apr 28, 2024
@bytemain bytemain merged commit ec0fc77 into main Apr 29, 2024
12 checks passed
@bytemain bytemain deleted the fix/design-module-styles branch April 29, 2024 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working 💄 style change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] DesignModule 样式适配
3 participants