Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support codicon transform on popover markdown content #3598

Merged
merged 16 commits into from
Apr 30, 2024

Conversation

erha19
Copy link
Member

@erha19 erha19 commented Apr 29, 2024

Types

  • 🎉 New Features

Background or solution

Before:
截屏2024-04-29 15 32 45

After:
截屏2024-04-29 17 31 45

Changelog

support codicon transform on popover content

@erha19 erha19 requested review from bytemain and Ricbet April 29, 2024 07:52
Copy link

railway-app bot commented Apr 29, 2024

This PR was not deployed automatically as @erha19 does not have access to the Railway project.

In order to get automatic PR deploys, please add @erha19 to the project inside the project settings page.

@opensumi opensumi bot added the 🎨 feature feature required label Apr 29, 2024
@erha19
Copy link
Member Author

erha19 commented Apr 29, 2024

/next

@erha19 erha19 changed the title feat: support codicon transform on popover content WIP: feat: support codicon transform on popover markdown content Apr 29, 2024
@opensumi
Copy link
Contributor

opensumi bot commented Apr 29, 2024

🎉 PR Next publish successful!

2.27.3-next-1714377336.0

@erha19
Copy link
Member Author

erha19 commented Apr 29, 2024

/next

@opensumi
Copy link
Contributor

opensumi bot commented Apr 29, 2024

🎉 PR Next publish successful!

2.27.3-next-1714378914.0

Copy link

codecov bot commented Apr 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.00%. Comparing base (e2c3494) to head (c01da0a).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3598      +/-   ##
==========================================
- Coverage   56.01%   56.00%   -0.02%     
==========================================
  Files        1503     1503              
  Lines       91459    91521      +62     
  Branches    18754    18756       +2     
==========================================
+ Hits        51229    51254      +25     
- Misses      33359    33393      +34     
- Partials     6871     6874       +3     
Flag Coverage Δ
jsdom 51.41% <100.00%> (-0.01%) ⬇️
node 15.64% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@erha19
Copy link
Member Author

erha19 commented Apr 29, 2024

/next

@opensumi
Copy link
Contributor

opensumi bot commented Apr 29, 2024

🎉 PR Next publish successful!

2.27.3-next-1714382708.0

@erha19
Copy link
Member Author

erha19 commented Apr 29, 2024

/next

@erha19 erha19 changed the title WIP: feat: support codicon transform on popover markdown content feat: support codicon transform on popover markdown content Apr 29, 2024
@Ricbet
Copy link
Member

Ricbet commented Apr 29, 2024

底下的尖尖好像没有了

@opensumi
Copy link
Contributor

opensumi bot commented Apr 29, 2024

🎉 PR Next publish successful!

2.27.3-next-1714383298.0

@erha19
Copy link
Member Author

erha19 commented Apr 29, 2024

底下的尖尖好像没有了

其实有的,要细看, 被阴影盖了一层刚好跟底色接近了

@erha19
Copy link
Member Author

erha19 commented Apr 29, 2024

/next

@opensumi
Copy link
Contributor

opensumi bot commented Apr 29, 2024

🎉 PR Next publish successful!

2.27.3-next-1714384997.0

@bytemain
Copy link
Member

这个小尖尖完全看不到了,感觉要修一下吧

@erha19
Copy link
Member Author

erha19 commented Apr 30, 2024

@Ricbet @bytemain 好了,层级调整了一下,让箭头盖到上面了

@erha19
Copy link
Member Author

erha19 commented Apr 30, 2024

/next

@erha19
Copy link
Member Author

erha19 commented Apr 30, 2024

/next

@opensumi
Copy link
Contributor

opensumi bot commented Apr 30, 2024

🎉 PR Next publish successful!

2.27.3-next-1714447365.0

@erha19
Copy link
Member Author

erha19 commented Apr 30, 2024

/next

@bytemain
Copy link
Member

这里不太对,component 库不能引用到 core-browser 里的内容

@bytemain
Copy link
Member

如果不能改枚举值就算了,component 包里,直接写个 number 也一样

@erha19
Copy link
Member Author

erha19 commented Apr 30, 2024

/next

@opensumi
Copy link
Contributor

opensumi bot commented Apr 30, 2024

🎉 PR Next publish successful!

2.27.3-next-1714448882.0

bytemain
bytemain previously approved these changes Apr 30, 2024
@erha19
Copy link
Member Author

erha19 commented Apr 30, 2024

/next

@opensumi
Copy link
Contributor

opensumi bot commented Apr 30, 2024

🎉 PR Next publish successful!

2.27.3-next-1714460210.0

@erha19
Copy link
Member Author

erha19 commented Apr 30, 2024

/next

@opensumi
Copy link
Contributor

opensumi bot commented Apr 30, 2024

🎉 PR Next publish successful!

2.27.3-next-1714461024.0

@erha19 erha19 merged commit c4c7566 into main Apr 30, 2024
12 checks passed
@erha19 erha19 deleted the feat/support-codicon-transform-on-popover branch April 30, 2024 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 feature feature required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants