Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adapt to the latest version of python extension #3600

Merged
merged 1 commit into from
Apr 30, 2024

Conversation

hacke2
Copy link
Member

@hacke2 hacke2 commented Apr 29, 2024

Types

  • 🎉 New Features

Background or solution

适配最新版 vscode-python 插件,由于 pylance 是闭源状态,无法知道其 API,用 vscode-python + pyright + python-debuger 插件来承接 python 需求,使用方式:

  1. 安装 python 插件列表:
  • vscode-python 2024.5.11021008
  • pyright: 1.1.360
  • python-debuger: 2024.5.11001012
  1. 配置需要关闭 vscode-python 默认语言服务配置:
{
  "python.languageServer": "None"
}

后续语言服务由 pyright 提供

  1. 修改插件进程 vscode 版本
    运行最新的 language-client 需要将插件进程 VS Code 版本调制最新

customVSCodeEngineVersion: 1.86.0

Changelog

feat: 空实现部分 API 已适配最新版本 Python 插件

Copy link

railway-app bot commented Apr 29, 2024

This PR was not deployed automatically as @hacke2 does not have access to the Railway project.

In order to get automatic PR deploys, please add @hacke2 to the project inside the project settings page.

@opensumi opensumi bot added the 🎨 feature feature required label Apr 29, 2024
@hacke2 hacke2 changed the title feat: adapter vscode-python-2024.5 feat: adapt vscode-python-2024.5 Apr 29, 2024
Copy link

codecov bot commented Apr 29, 2024

Codecov Report

Attention: Patch coverage is 38.80597% with 41 lines in your changes are missing coverage. Please review.

Project coverage is 56.00%. Comparing base (e2c3494) to head (391d392).

Files Patch % Lines
...tension/src/hosted/api/vscode/env/telemetry-ext.ts 18.18% 33 Missing and 3 partials ⚠️
...tension/src/hosted/api/vscode/env/envApiFactory.ts 50.00% 4 Missing ⚠️
...ension/src/hosted/api/vscode/ext.host.workspace.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3600      +/-   ##
==========================================
- Coverage   56.01%   56.00%   -0.01%     
==========================================
  Files        1503     1504       +1     
  Lines       91459    91518      +59     
  Branches    18754    18760       +6     
==========================================
+ Hits        51229    51253      +24     
- Misses      33359    33392      +33     
- Partials     6871     6873       +2     
Flag Coverage Δ
jsdom 51.41% <38.80%> (-0.01%) ⬇️
node 15.64% <7.46%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hacke2 hacke2 requested review from bytemain and bk1012 April 30, 2024 02:52
@bytemain bytemain changed the title feat: adapt vscode-python-2024.5 feat: adapt to the latest version of python extension Apr 30, 2024
@bytemain bytemain merged commit 818a21e into main Apr 30, 2024
15 checks passed
@bytemain bytemain deleted the feat/python-2024.5.11021008 branch April 30, 2024 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 feature feature required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants