Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reconnecting ws channel not work #3612

Merged
merged 10 commits into from
May 6, 2024
Merged

fix: reconnecting ws channel not work #3612

merged 10 commits into from
May 6, 2024

Conversation

bytemain
Copy link
Member

@bytemain bytemain commented May 6, 2024

Types

  • 🐛 Bug Fixes

Background or solution

  1. 修复 main 分支上的重连 node service
  2. 修复偶现重启 ext host 不工作

Changelog

Fix reconnect node service does not work
Fix restart ext host does not work

Copy link

railway-app bot commented May 6, 2024

This PR is being deployed to Railway 🚅

core: ◻️ REMOVED

@opensumi opensumi bot added the 🐞 bug Something isn't working label May 6, 2024
Copy link

codecov bot commented May 6, 2024

Codecov Report

Attention: Patch coverage is 49.63504% with 69 lines in your changes are missing coverage. Please review.

Project coverage is 56.05%. Comparing base (b5df89c) to head (9a4c1ad).

Files Patch % Lines
...ackages/extension/src/browser/extension.service.ts 7.69% 27 Missing and 9 partials ⚠️
packages/utils/src/map.ts 42.10% 11 Missing ⚠️
...kages/connection/src/browser/ws-channel-handler.ts 76.47% 6 Missing and 2 partials ⚠️
packages/utils/src/cancellation.ts 20.00% 4 Missing ⚠️
...ommon/connection/drivers/reconnecting-websocket.ts 77.77% 2 Missing ⚠️
...connection/src/common/connection/drivers/stream.ts 85.71% 2 Missing ⚠️
...ckages/connection/src/common/rpc-service/center.ts 60.00% 2 Missing ⚠️
packages/core-browser/src/bootstrap/connection.ts 50.00% 2 Missing ⚠️
packages/extension/src/node/extension.service.ts 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3612      +/-   ##
==========================================
- Coverage   56.05%   56.05%   -0.01%     
==========================================
  Files        1510     1510              
  Lines       91707    91768      +61     
  Branches    18795    18810      +15     
==========================================
+ Hits        51407    51439      +32     
- Misses      33433    33456      +23     
- Partials     6867     6873       +6     
Flag Coverage Δ
jsdom 51.47% <36.49%> (-0.01%) ⬇️
node 15.64% <35.03%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bytemain bytemain merged commit 197b8ef into main May 6, 2024
12 checks passed
@bytemain bytemain deleted the fix/reconnect-power branch May 6, 2024 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants