Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: validate copy and move operations #3754

Merged
merged 1 commit into from
Jun 11, 2024
Merged

fix: validate copy and move operations #3754

merged 1 commit into from
Jun 11, 2024

Conversation

bytemain
Copy link
Member

Types

  • 🐛 Bug Fixes

Background or solution

之前如果复制文件到父级,会导致文件丢失(执行 fs-extra.move 后,它内部会删除源文件)

vscode 有一层前置检查:

CleanShot 2024-06-11 at 10 40 29@2x

加入一次前置检查

CleanShot 2024-06-11 at 10 43 00@2x

Changelog

fix: validate copy and move operations

Copy link

railway-app bot commented Jun 11, 2024

🚅 Previously deployed to Railway in the core project. Environment has been deleted.

@opensumi opensumi bot added the 🐞 bug Something isn't working label Jun 11, 2024
Copy link

codecov bot commented Jun 11, 2024

Codecov Report

Attention: Patch coverage is 81.81818% with 6 lines in your changes missing coverage. Please review.

Project coverage is 55.35%. Comparing base (0506968) to head (c07036a).
Report is 1 commits behind head on main.

Files Patch % Lines
packages/utils/src/file-uri.ts 73.33% 3 Missing and 1 partial ⚠️
...file-service/src/node/disk-file-system.provider.ts 88.88% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3754      +/-   ##
==========================================
- Coverage   55.35%   55.35%   -0.01%     
==========================================
  Files        1537     1537              
  Lines       93851    93863      +12     
  Branches    19284    19287       +3     
==========================================
+ Hits        51954    51959       +5     
- Misses      34755    34761       +6     
- Partials     7142     7143       +1     
Flag Coverage Δ
jsdom 50.81% <54.54%> (-0.01%) ⬇️
node 15.57% <81.81%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@erha19 erha19 merged commit 5d722c5 into main Jun 11, 2024
13 checks passed
@erha19 erha19 deleted the fix/validate-copy branch June 11, 2024 04:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants