Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct uri equality check with comments service #3755

Merged
merged 2 commits into from
Jun 11, 2024

Conversation

erha19
Copy link
Member

@erha19 erha19 commented Jun 11, 2024

Types

  • 🐛 Bug Fixes

Background or solution

image

Changelog

correct uri equality check with comments service

@erha19 erha19 requested review from bytemain and Ricbet June 11, 2024 06:34
Copy link

railway-app bot commented Jun 11, 2024

This PR was not deployed automatically as @erha19 does not have access to the Railway project.

In order to get automatic PR deploys, please add @erha19 to the project inside the project settings page.

@opensumi opensumi bot added the 🐞 bug Something isn't working label Jun 11, 2024
@erha19
Copy link
Member Author

erha19 commented Jun 11, 2024

/next

@opensumi
Copy link
Contributor

opensumi bot commented Jun 11, 2024

🎉 PR Next publish successful!

3.1.1-next-1718087893.0

Copy link

codecov bot commented Jun 11, 2024

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 55.35%. Comparing base (e1c2b65) to head (f5aac9a).

Files Patch % Lines
packages/comments/src/browser/comments.service.ts 0.00% 6 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3755      +/-   ##
==========================================
- Coverage   55.35%   55.35%   -0.01%     
==========================================
  Files        1537     1537              
  Lines       93867    93871       +4     
  Branches    19279    19283       +4     
==========================================
- Hits        51961    51959       -2     
- Misses      34763    34769       +6     
  Partials     7143     7143              
Flag Coverage Δ
jsdom 50.81% <0.00%> (-0.01%) ⬇️
node 15.57% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@erha19
Copy link
Member Author

erha19 commented Jun 11, 2024

/next

@opensumi
Copy link
Contributor

opensumi bot commented Jun 11, 2024

🎉 PR Next publish successful!

3.1.1-next-1718093890.0

@erha19 erha19 merged commit 8f27e53 into main Jun 11, 2024
12 checks passed
@erha19 erha19 deleted the fix/comment-service-uri-equal branch June 11, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants