Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: adjust z-index values for layout components #3769

Merged
merged 1 commit into from
Jun 12, 2024

Conversation

erha19
Copy link
Member

@erha19 erha19 commented Jun 12, 2024

Types

  • 💄 Style Changes

Background or solution

不应该硬编码层级关系,将层级关系由子组件自行控制

Changelog

adjust z-index values for layout components

@erha19 erha19 requested review from bytemain and Ricbet June 12, 2024 08:23
Copy link

railway-app bot commented Jun 12, 2024

This PR was not deployed automatically as @erha19 does not have access to the Railway project.

In order to get automatic PR deploys, please add @erha19 to the project inside the project settings page.

Copy link

codecov bot commented Jun 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.33%. Comparing base (30f81b6) to head (19820bc).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3769   +/-   ##
=======================================
  Coverage   55.32%   55.33%           
=======================================
  Files        1540     1540           
  Lines       93915    93915           
  Branches    19282    19290    +8     
=======================================
+ Hits        51960    51967    +7     
+ Misses      34811    34805    -6     
+ Partials     7144     7143    -1     
Flag Coverage Δ
jsdom 50.79% <ø> (+<0.01%) ⬆️
node 15.56% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@erha19 erha19 merged commit b2208ab into main Jun 12, 2024
12 checks passed
@erha19 erha19 deleted the style/remove-useless-z-index branch June 12, 2024 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants