Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support show inline chat on diff editor #3774

Merged
merged 14 commits into from
Jun 20, 2024

Conversation

erha19
Copy link
Member

@erha19 erha19 commented Jun 13, 2024

Types

  • 🎉 New Features

Background or solution

image

Changelog

support show inline chat on diff editor

@erha19 erha19 requested review from bytemain and Ricbet June 13, 2024 10:37
Copy link

railway-app bot commented Jun 13, 2024

This PR was not deployed automatically as @erha19 does not have access to the Railway project.

In order to get automatic PR deploys, please add @erha19 to the project inside the project settings page.

@opensumi opensumi bot added the 🎨 feature feature required label Jun 13, 2024
@erha19
Copy link
Member Author

erha19 commented Jun 13, 2024

/next

@opensumi
Copy link
Contributor

opensumi bot commented Jun 13, 2024

🎉 PR Next publish successful!

3.1.1-next-1718284418.0

@opensumi
Copy link
Contributor

opensumi bot commented Jun 13, 2024

🎉 PR Next publish successful!

3.1.1-next-1718284437.0

Copy link

codecov bot commented Jun 13, 2024

Codecov Report

Attention: Patch coverage is 10.00000% with 18 lines in your changes missing coverage. Please review.

Project coverage is 55.22%. Comparing base (34be2ab) to head (a4c5c5a).

Files Patch % Lines
...widget/inline-chat/inline-chat.feature.registry.ts 0.00% 13 Missing and 3 partials ⚠️
...es/editor/src/browser/editor-collection.service.ts 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3774      +/-   ##
==========================================
- Coverage   55.22%   55.22%   -0.01%     
==========================================
  Files        1544     1544              
  Lines       94279    94297      +18     
  Branches    19343    19338       -5     
==========================================
+ Hits        52066    52072       +6     
- Misses      35040    35049       +9     
- Partials     7173     7176       +3     
Flag Coverage Δ
jsdom 50.65% <10.00%> (-0.01%) ⬇️
node 15.60% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@erha19
Copy link
Member Author

erha19 commented Jun 13, 2024

/next

@opensumi
Copy link
Contributor

opensumi bot commented Jun 13, 2024

🎉 PR Next publish successful!

3.1.1-next-1718286713.0

@Ricbet
Copy link
Member

Ricbet commented Jun 14, 2024

diff 的左侧通常是只读文件,也需要展示 inline chat 吗

@erha19
Copy link
Member Author

erha19 commented Jun 14, 2024

diff 的左侧通常是只读文件,也需要展示 inline chat 吗

确实不需要,有个 hover widget 就行了

@erha19 erha19 force-pushed the feat/support-hover-widget-on-diff-editor branch from 11d419f to f986839 Compare June 15, 2024 14:44
@erha19
Copy link
Member Author

erha19 commented Jun 15, 2024

/next

@opensumi
Copy link
Contributor

opensumi bot commented Jun 15, 2024

🎉 PR Next publish successful!

3.1.2-next-1718462882.0

@erha19
Copy link
Member Author

erha19 commented Jun 15, 2024

/next

@opensumi
Copy link
Contributor

opensumi bot commented Jun 15, 2024

🎉 PR Next publish successful!

3.1.2-next-1718463207.0

@erha19
Copy link
Member Author

erha19 commented Jun 16, 2024

/next

@opensumi
Copy link
Contributor

opensumi bot commented Jun 16, 2024

🎉 PR Next publish successful!

3.1.2-next-1718546408.0

@bytemain bytemain changed the title feat: support hover widget on diff editor feat: support show inline chat on diff editor Jun 17, 2024
@erha19
Copy link
Member Author

erha19 commented Jun 18, 2024

/next

@opensumi
Copy link
Contributor

opensumi bot commented Jun 18, 2024

🎉 PR Next publish successful!

3.1.2-next-1718694575.0

@erha19
Copy link
Member Author

erha19 commented Jun 19, 2024

/next

@opensumi
Copy link
Contributor

opensumi bot commented Jun 19, 2024

🎉 PR Next publish successful!

3.1.2-next-1718766864.0

@erha19
Copy link
Member Author

erha19 commented Jun 19, 2024

/next

1 similar comment
@erha19
Copy link
Member Author

erha19 commented Jun 19, 2024

/next

@opensumi
Copy link
Contributor

opensumi bot commented Jun 19, 2024

🎉 PR Next publish successful!

3.1.2-next-1718769324.0

@erha19 erha19 merged commit 0dca73a into main Jun 20, 2024
12 checks passed
@erha19 erha19 deleted the feat/support-hover-widget-on-diff-editor branch June 20, 2024 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 feature feature required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants