Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "feat: optimize tree performance" #3783

Merged
merged 1 commit into from
Jun 17, 2024

Conversation

bytemain
Copy link
Member

Reverts #3742

这个优化会导致如果使用带 / 的 name 作为树节点的话,后期计算树的更新有问题,待修复再合

@opensumi opensumi bot added the 🎨 feature feature required label Jun 17, 2024
Copy link

railway-app bot commented Jun 17, 2024

🚅 Previously deployed to Railway in the core project. Environment has been deleted.

Copy link

codecov bot commented Jun 17, 2024

Codecov Report

Attention: Patch coverage is 54.38596% with 52 lines in your changes missing coverage. Please review.

Project coverage is 55.20%. Comparing base (ef65ac4) to head (3655efe).

Files Patch % Lines
...kages/components/src/recycle-tree/tree/TreeNode.ts 70.17% 15 Missing and 2 partials ⚠️
...src/browser/services/opened-editor-tree.service.ts 39.13% 12 Missing and 2 partials ⚠️
...line/src/browser/services/outline-model.service.ts 20.00% 4 Missing ⚠️
...c/browser/editor/debug-hover-tree.model.service.ts 50.00% 3 Missing ⚠️
...r/view/console/debug-console-tree.model.service.ts 40.00% 3 Missing ⚠️
...owser/view/watch/debug-watch-tree.model.service.ts 25.00% 3 Missing ⚠️
...ges/markers/src/browser/tree/tree-model.service.ts 0.00% 2 Missing and 1 partial ⚠️
...rc/browser/services/opened-editor-model.service.ts 40.00% 3 Missing ⚠️
...ycle-tree/tree/model/treeState/TreeStateManager.ts 75.00% 0 Missing and 1 partial ⚠️
...ed-editor/src/browser/opened-editor-node.define.ts 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3783      +/-   ##
==========================================
- Coverage   55.25%   55.20%   -0.05%     
==========================================
  Files        1545     1544       -1     
  Lines       94179    94168      -11     
  Branches    19331    19326       -5     
==========================================
- Hits        52035    51988      -47     
- Misses      34978    35009      +31     
- Partials     7166     7171       +5     
Flag Coverage Δ
jsdom 50.68% <54.38%> (-0.05%) ⬇️
node 15.52% <4.38%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bytemain bytemain merged commit 6273dba into main Jun 17, 2024
13 checks passed
@bytemain bytemain deleted the revert-3742-feat/optimize-tree-perf-1 branch June 17, 2024 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 feature feature required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants