Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: inline chat code blocks controller #3809

Merged
merged 3 commits into from
Jun 27, 2024

Conversation

Ricbet
Copy link
Member

@Ricbet Ricbet commented Jun 26, 2024

Types

  • 🐛 Bug Fixes

Background or solution

之前处理模型回答的代码块逻辑有问题,现调整成更合理的方式

Changelog

修复 inline chat 流式渲染偶现代码块不完整的问题

@Ricbet Ricbet requested review from erha19 and bytemain June 26, 2024 08:58
Copy link

railway-app bot commented Jun 26, 2024

This PR was not deployed automatically as @Ricbet does not have access to the Railway project.

In order to get automatic PR deploys, please add @Ricbet to the project inside the project settings page.

@opensumi opensumi bot added the 🐞 bug Something isn't working label Jun 26, 2024
Copy link

codecov bot commented Jun 26, 2024

Codecov Report

Attention: Patch coverage is 0% with 32 lines in your changes missing coverage. Please review.

Project coverage is 55.08%. Comparing base (5a66542) to head (14771f1).

Files Patch % Lines
...owser/widget/inline-chat/inline-chat-controller.ts 0.00% 19 Missing and 3 partials ⚠️
...rowser/widget/inline-diff/inline-diff-previewer.ts 0.00% 9 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3809      +/-   ##
==========================================
- Coverage   55.08%   55.08%   -0.01%     
==========================================
  Files        1550     1550              
  Lines       94558    94559       +1     
  Branches    19375    19371       -4     
==========================================
- Hits        52088    52085       -3     
- Misses      35272    35277       +5     
+ Partials     7198     7197       -1     
Flag Coverage Δ
jsdom 50.52% <0.00%> (-0.01%) ⬇️
node 15.56% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Ricbet Ricbet merged commit 07a6f8a into main Jun 27, 2024
12 checks passed
@Ricbet Ricbet deleted the chore/improve-inline-chat-controller branch June 27, 2024 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants