Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add pty proxy deferred #3811

Merged
merged 1 commit into from
Jun 28, 2024
Merged

fix: add pty proxy deferred #3811

merged 1 commit into from
Jun 28, 2024

Conversation

winjo
Copy link
Contributor

@winjo winjo commented Jun 27, 2024

Types

  • 🐛 Bug Fixes

Background or solution

双容器下 spawn 时未等待 pty proxy ready 导致 undefiend 错误,增加 pty deferred

Changelog

@winjo winjo requested review from life2015 and bytemain June 27, 2024 12:35
@opensumi opensumi bot added the 🐞 bug Something isn't working label Jun 27, 2024
Copy link

codecov bot commented Jun 27, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 55.32%. Comparing base (4d7306d) to head (429bf86).

Files Patch % Lines
...kages/terminal-next/src/node/pty.manager.remote.ts 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             v3.1    #3811      +/-   ##
==========================================
+ Coverage   55.17%   55.32%   +0.14%     
==========================================
  Files        1549     1540       -9     
  Lines       96119    93908    -2211     
  Branches    19966    19282     -684     
==========================================
- Hits        53038    51956    -1082     
+ Misses      35651    34803     -848     
+ Partials     7430     7149     -281     
Flag Coverage Δ
jsdom 50.78% <0.00%> (+0.20%) ⬆️
node 15.55% <83.33%> (-0.20%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@winjo
Copy link
Contributor Author

winjo commented Jun 28, 2024

/next

@opensumi
Copy link
Contributor

opensumi bot commented Jun 28, 2024

🎉 PR Next publish successful!

3.1.4-next-1719541057.0

@bytemain bytemain merged commit 7c7abcc into v3.1 Jun 28, 2024
14 checks passed
@bytemain bytemain deleted the fix/pty-proxy-ready branch June 28, 2024 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants