fix: factory support multiple value

opensumi · Dec 3, 2023 · edaa25e · edaa25e
1 parent 69443de
commit edaa25e
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 23 deletions.
diff --git a/src/injector.ts b/src/injector.ts
@@ -533,8 +533,7 @@ export class Injector {
     const { creator, token } = ctx;
 
     const value = applyHooks(creator.useFactory(this), token, this.hookStore);
-    creator.instance = new Set([value]);
-
+    creator.instance ? creator.instance.add(value) : (creator.instance = new Set([value]));
     return value;
   }
 }
diff --git a/test/injector.test.ts b/test/injector.test.ts
@@ -1,23 +1,4 @@
-import {
-  Autowired,
-  Injectable,
-  Injector,
-  INJECTOR_TOKEN,
-  Inject,
-  Optional,
-  Aspect,
-  Before,
-  After,
-  Around,
-  HookType,
-  IBeforeJoinPoint,
-  IAfterJoinPoint,
-  IAroundJoinPoint,
-  AfterReturning,
-  IAfterReturningJoinPoint,
-  AfterThrowing,
-  IAfterThrowingJoinPoint,
-} from '../src';
+import { Autowired, Injectable, Injector, INJECTOR_TOKEN, Inject, Optional } from '../src';
 import * as InjectorError from '../src/error';
 import { getInjectorOfInstance } from '../src/helper';
 
@@ -420,7 +401,7 @@ describe('test injector work', () => {
       expect(injector1.id).not.toBe(injector2.id);
     });
 
-    it('实例对象有 ID 数据', () => {
+    it('could get id from the instance', () => {
       const injector = new Injector();
       const instance1 = injector.get(A);
       const instance2 = injector.get(A);