Skip to content
This repository has been archived by the owner on Feb 1, 2024. It is now read-only.

Commit

Permalink
Catch & log exception in emailing contributors
Browse files Browse the repository at this point in the history
Catch exceptions thrown when trying to email contributors about facility
claim approvals and profile changes, sending only the Facility Claim ID
to Rollbar. Afterward, continue sending a response as usual.
  • Loading branch information
Kelly Innes committed Jun 18, 2019
1 parent 10188bc commit 8406351
Showing 1 changed file with 27 additions and 4 deletions.
31 changes: 27 additions & 4 deletions src/django/api/views.py
Original file line number Diff line number Diff line change
@@ -1,9 +1,11 @@
import operator
import os
import sys

from datetime import datetime
from functools import reduce

from django.conf import settings
from django.core.files.uploadedfile import InMemoryUploadedFile
from django.db import transaction
from django.db.models import F, Q
Expand Down Expand Up @@ -76,6 +78,19 @@
from api.exceptions import BadRequestException


def _report_facility_claim_email_error_to_rollbar(claim):
ROLLBAR = getattr(settings, 'ROLLBAR', {})

if ROLLBAR:
import rollbar
rollbar.report.exc_info(
sys.exc_info(),
extra_data={
'claim_id': claim.id,
}
)


@permission_classes((AllowAny,))
class SubmitNewUserForm(CreateAPIView):
serializer_class = UserSerializer
Expand Down Expand Up @@ -1475,8 +1490,11 @@ def approve_claim(self, request, pk=None):

send_claim_facility_approval_email(request, claim)

send_approved_claim_notice_to_list_contributors(request,
claim)
try:
send_approved_claim_notice_to_list_contributors(request,
claim)
except Exception:
_report_facility_claim_email_error_to_rollbar(claim)

response_data = FacilityClaimDetailsSerializer(claim).data
return Response(response_data)
Expand Down Expand Up @@ -1646,8 +1664,13 @@ def get_claimed_details(self, request, pk=None):
)

updated_claim = FacilityClaim.objects.get(pk=pk)
send_claim_update_notice_to_list_contributors(request,
updated_claim)

try:
send_claim_update_notice_to_list_contributors(request,
updated_claim)
except Exception:
_report_facility_claim_email_error_to_rollbar(updated_claim)

response_data = ApprovedFacilityClaimSerializer(updated_claim).data
return Response(response_data)
except FacilityClaim.DoesNotExist:
Expand Down

0 comments on commit 8406351

Please sign in to comment.