Skip to content
This repository has been archived by the owner on Feb 1, 2024. It is now read-only.

PUT request to update embed map settings takes 5 to 12 seconds to complete on staging #1660

Closed
jwalgran opened this issue Feb 17, 2022 · 4 comments

Comments

@jwalgran
Copy link
Contributor

jwalgran commented Feb 17, 2022

Overview

PUR request to update embed map settings takes 5 to 12 seconds to complete on staging. To date we have not reproduced the issue in development or production.

This issue covers investigation into the issue and a fix if it is small. If it is not a small fix create a follow up issue.

We suspect that the issue may be that we are reindexing searchable fields when any change is made to the map. We should only trigger re indexing when searchable fields change

@jwalgran jwalgran changed the title PUR request to update embed map settings takes 5 to 12 seconds to complete on staging PUT request to update embed map settings takes 5 to 12 seconds to complete on staging Feb 17, 2022
@emilyhu0106 emilyhu0106 self-assigned this Feb 17, 2022
@obrienad obrienad changed the title PUT request to update embed map settings takes 5 to 12 seconds to complete on staging PUR request to update embed map settings takes 5 to 12 seconds to complete on staging Feb 18, 2022
@obrienad obrienad changed the title PUR request to update embed map settings takes 5 to 12 seconds to complete on staging PUT request to update embed map settings takes 5 to 12 seconds to complete on staging Feb 18, 2022
@emilyhu0106
Copy link
Contributor

After modifying embedded custom text search in #1652, the PUT request speed on staging for map style changes and field visibility changes is significantly faster and as fast as in development, but still takes 5-12 seconds for the searchability update.

Tai and I think we can either add a sentence to acknowledge the users in the description or keep investigating in the cause. @jwalgran What's your opinion on this?

@emilyhu0106
Copy link
Contributor

@jwalgran Do you mind giving your input on this comment?

@jwalgran
Copy link
Contributor Author

Sorry I missed the previous notification.

I do think a "toast" message saying that updating search fields can take some time is a good idea but I also thing we should do what we regularly do for long running requests and a loading spinner while the PUT request is pending and clear the loading spinner when the the PUT request either succeeds or fails.

@jwalgran
Copy link
Contributor Author

Adding the spinner should be implemented under https://github.com/open-apparel-registry/open-apparel-registry-clients/issues/79

The PR to add the spinner should reverence both this issue and https://github.com/open-apparel-registry/open-apparel-registry-clients/issues/79 so that everything is linked together and referenceable.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants