Skip to content
This repository has been archived by the owner on Feb 1, 2024. It is now read-only.

App crashes when logging in after zooming in #822

Closed
rajadain opened this issue Sep 19, 2019 · 1 comment
Closed

App crashes when logging in after zooming in #822

rajadain opened this issue Sep 19, 2019 · 1 comment
Assignees
Labels
+ bug Something isn't working

Comments

@rajadain
Copy link
Contributor

Overview

If the vector tile layer is turned on, and you zoom in all the way and pick a facility, then click "Log In" in the top right, the app crashes.

Unhandled Rejection (TypeError): layer is undefined
https://github.com/open-apparel-registry/open-apparel-registry/blob/8b262ae7619b40045c1e720d23d8e93aa52f3941/src/app/src/components/VectorTileFacilityGridLayer.jsx#L97

Expected Behavior

The app does not crash, and allows logging in.

Actual Behavior

The app crashes.

Steps to Reproduce

  • Have the vector tile layer turned on
  • Zoom all the way in to the facility level and select one
  • Click "Log In" in the top right
  • Wait a few seconds
  • See the app crash

Demo

image

2019-09-19 12 09 00

@rajadain rajadain added the bug Something isn't working label Sep 19, 2019
@kellyi kellyi added the + label Sep 29, 2019
@kellyi
Copy link
Contributor

kellyi commented Sep 29, 2019

This should be pretty straightforward to fix and we'll need to do that before releasing vector tiles to production.

@kellyi kellyi self-assigned this Sep 30, 2019
kellyi pushed a commit that referenced this issue Sep 30, 2019
Fix vector tile map crashes on login/logout

Connects #822
@rajadain rajadain closed this as completed Oct 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
+ bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants