This repository has been archived by the owner on Feb 1, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
When a facility list item is submitted with
create=false
and there isno match found, a
FacilityListItem
is created withfacility_id=None
.When another facility list item is submitted which exact matches that
FacilityListItem
, an error was being thrown. Instead, we now filterout
FacilityListItems
where thefacility_id=None
, allowing us to matchto the next best option (if one exists) or pass the
FacilityListItem
on to the dedupe process.
Connects #1580
Testing Instructions
create=false
twice. The second submission should result in ERROR_MATCHINGChecklist
fixup!
commits have been squashed