Skip to content
This repository has been archived by the owner on Feb 1, 2024. It is now read-only.

Exclude details from facility list API by defaut #1739

Merged
merged 5 commits into from
Mar 20, 2022
Merged

Exclude details from facility list API by defaut #1739

merged 5 commits into from
Mar 20, 2022

Commits on Mar 20, 2022

  1. Correct the swagger summary for the facilities GET endpoint 

    We reduced the max page size to 50 a while ago so that the more expensive to
build responses that include all the details required to generate CSV/Excel
downlod do not exceed our the cloudfront timeout.
    @jwalgran
    jwalgran committed Mar 20, 2022
    Configuration menu
    Copy the full SHA
    f18709f View commit details
    Browse the repository at this point in the history

  2. Exclude details from facility list API by default 

    Serializing contributor fields and extended fields requires multiple database
lookups and is expensive. We add a `detail` query parameter to the facilities
list and only include the `contributors`, `contributor_fields`, and
`extended_fields` in the serialized output if that `detail` parameter is set to
true.

This change creates a regressing in the CSV downloads because the additional
fields are no longer available. That should be fixed in a future commit.
    @jwalgran
    jwalgran committed Mar 20, 2022
    Configuration menu
    Copy the full SHA
    c0e287d View commit details
    Browse the repository at this point in the history

  3. Fetch full details when download facilities for CSV/Excel 

    Previously we defaulted to returning the full details so previously loaded data
was ready for CSV/Excel download. Now that we default to excluding those details
we need to update the action chain to refetch facilities.
    @jwalgran
    jwalgran committed Mar 20, 2022
    Configuration menu
    Copy the full SHA
    6464be0 View commit details
    Browse the repository at this point in the history

  4. Prevent UI interaction from interfering with facility download 

    While a download is in progress infinite scroll events from the component
showing the list were previously resulting in duplicate data being added to the
CSV. We attempt to resolve the issue by disabling infinite scroll handling while
downloading.
    @jwalgran
    jwalgran committed Mar 20, 2022
    Configuration menu
    Copy the full SHA
    6e16747 View commit details
    Browse the repository at this point in the history

  5. Update CHANGELOG

    @jwalgran
    jwalgran committed Mar 20, 2022
    Configuration menu
    Copy the full SHA
    63f5e7b View commit details
    Browse the repository at this point in the history