This repository has been archived by the owner on Feb 1, 2024. It is now read-only.
Avoid exception when parsing arrays in raw data #1910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When submitting a facility via the API the raw data for fields like `product_type` can contain an array value. Attempting to call `fload()` on a list was raiding a `TypeError` rather than a `ValueError`, resulting in an unhandled exception in the `try_parse_int_from_float` helper.
jwalgran
force-pushed
the
ogr/bugfix/jcw/embed-array-parsing
branch
from
e7e2945
to
fd4d145
Compare
|
Merging without review because the change is the same across branches. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This is the same change as #1904 targeted at
ogr/developConnects #1903
Testing Instructions
Skip testing because the change is identical in both branches.
Checklist
fixup!commits have been squasheddevelopvs.ogr/develop)