Skip to content
This repository has been archived by the owner on Feb 1, 2024. It is now read-only.

Add parent company to facility claim #626

Merged
merged 1 commit into from
Jun 25, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
- Order facility claim notes from oldest to newest on dashboard [#596](https://github.com/open-apparel-registry/open-apparel-registry/pull/596)
- Prevent users from submitting another claim for a facility when they have a first claim still pending [#601](https://github.com/open-apparel-registry/open-apparel-registry/pull/601)
- Email contributors when facility claims are approved or claim profiles are updated [#611](https://github.com/open-apparel-registry/open-apparel-registry/pull/611)
- Add `parent_company` field to facility claims [#626](https://github.com/open-apparel-registry/open-apparel-registry/pull/626)

### Deprecated

Expand Down
30 changes: 30 additions & 0 deletions src/app/src/actions/claimFacility.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,9 @@ import {
logErrorAndDispatchFailure,
makeGetFacilityByOARIdURL,
makeClaimFacilityAPIURL,
makeParentCompanyOptionsAPIURL,
claimAFacilityFormIsValid,
mapDjangoChoiceTuplesToSelectOptions,
} from '../util/util';

export const startFetchClaimFacilityData = createAction('START_FETCH_CLAIM_FACILITY_DATA');
Expand Down Expand Up @@ -40,6 +42,8 @@ export const updateClaimAFacilityPhoneNumber =
createAction('UPDATE_CLAIM_A_FACILITY_PHONE_NUMBER');
export const updateClaimAFacilityCompany =
createAction('UPDATE_CLAIM_A_FACILITY_COMPANY');
export const updateClaimAFacilityParentCompany =
createAction('UPDATE_CLAIM_A_FACILITY_PARENT_COMPANY');
export const updateClaimAFacilityWebsite =
createAction('UPDATE_CLAIM_A_FACILITY_WEBSITE');
export const updateClaimAFacilityDescription =
Expand Down Expand Up @@ -73,6 +77,7 @@ export function submitClaimAFacilityData(oarID) {
const postData = mapKeys(
Object.assign({}, formData, {
preferredContactMethod: get(formData, 'preferredContactMethod.value', null),
parentCompany: get(formData, 'parentCompany.value', null),
}),
(_, k) => snakeCase(k),
);
Expand All @@ -89,3 +94,28 @@ export function submitClaimAFacilityData(oarID) {
)));
};
}

export const startFetchParentCompanyOptions =
createAction('START_FETCH_PARENT_COMPANY_OPTIONS');
export const failFetchParentCompanyOptions =
createAction('FAIL_FETCH_PARENT_COMPANY_OPTIONS');
export const completeFetchParentCompanyOptions =
createAction('COMPLETE_FETCH_PARENT_COMPANY_OPTIONS');
export const resetParentCompanyOptions =
createAction('RESET_PARENT_COMPANY_OPTIONS');

export function fetchParentCompanyOptions() {
return (dispatch) => {
dispatch(startFetchParentCompanyOptions());

return csrfRequest
.get(makeParentCompanyOptionsAPIURL())
.then(({ data }) => mapDjangoChoiceTuplesToSelectOptions(data))
.then(data => dispatch(completeFetchParentCompanyOptions(data)))
.catch(err => dispatch(logErrorAndDispatchFailure(
err,
'An error prevented fetching parent company options',
failFetchParentCompanyOptions,
)));
};
}
2 changes: 2 additions & 0 deletions src/app/src/actions/claimedFacilityDetails.js
Original file line number Diff line number Diff line change
Expand Up @@ -115,3 +115,5 @@ export const updateClaimedFacilityOfficeCountry =
createAction('UPDATE_CLAIMED_FACILITY_OFFICE_COUNTRY');
export const updateClaimedFacilityOfficePhone =
createAction('UPDATE_CLAIMED_FACILITY_OFFICE_PHONE');
export const updateClaimedFacilityParentCompany =
createAction('UPDATE_CLAIMED_FACILITY_PARENT_COMPANY');
21 changes: 15 additions & 6 deletions src/app/src/components/ClaimFacility.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ import ClaimFacilityStepper from '../components/ClaimFacilityStepper';
import {
fetchClaimFacilityData,
clearClaimFacilityDataAndForm,
fetchParentCompanyOptions,
} from '../actions/claimFacility';

import { facilityDetailsPropType } from '../util/propTypes';
Expand All @@ -38,7 +39,7 @@ function ClaimFacility({
data,
fetching,
error,
getFacilityData,
getClaimData,
clearClaimData,
userHasSignedIn,
match: {
Expand All @@ -47,11 +48,13 @@ function ClaimFacility({
},
},
}) {
/* eslint-disable react-hooks/exhaustive-deps */
useEffect(() => {
getFacilityData();
getClaimData();

return clearClaimData;
}, [getFacilityData, clearClaimData]);
}, []);
/* eslint-enable react-hooks/exhaustive-deps */

if (fetching) {
return <CircularProgress />;
Expand Down Expand Up @@ -120,14 +123,17 @@ ClaimFacility.propTypes = {
data: facilityDetailsPropType,
fetching: bool.isRequired,
error: arrayOf(string),
getFacilityData: func.isRequired,
getClaimData: func.isRequired,
clearClaimData: func.isRequired,
userHasSignedIn: bool.isRequired,
};

function mapStateToProps({
claimFacility: {
facilityData: { data, fetching, error },
parentCompanyOptions: {
fetching: fetchingParentCompanyOptions,
},
},
auth: {
user: { user },
Expand All @@ -136,7 +142,7 @@ function mapStateToProps({
}) {
return {
data,
fetching: fetching || sessionFetching,
fetching: fetching || sessionFetching || fetchingParentCompanyOptions,
userHasSignedIn: !!user,
error,
};
Expand All @@ -151,7 +157,10 @@ function mapDispatchToProps(
},
) {
return {
getFacilityData: () => dispatch(fetchClaimFacilityData(oarID)),
getClaimData: () => {
dispatch(fetchParentCompanyOptions());
return dispatch(fetchClaimFacilityData(oarID));
},
clearClaimData: () => dispatch(clearClaimFacilityDataAndForm()),
};
}
Expand Down
68 changes: 65 additions & 3 deletions src/app/src/components/ClaimFacilityFacilityInfoStep.jsx
Original file line number Diff line number Diff line change
@@ -1,17 +1,19 @@
import React from 'react';
import { bool, func, string } from 'prop-types';
import { bool, func, number, shape, string } from 'prop-types';
import { connect } from 'react-redux';
import Typography from '@material-ui/core/Typography';
import TextField from '@material-ui/core/TextField';
import InputLabel from '@material-ui/core/InputLabel';
import { isEmpty } from 'validator';
import isEmpty from 'lodash/isEmpty';
import Select from 'react-select';

import RequiredAsterisk from './RequiredAsterisk';

import {
updateClaimAFacilityCompany,
updateClaimAFacilityWebsite,
updateClaimAFacilityDescription,
updateClaimAFacilityParentCompany,
} from '../actions/claimFacility';

import { getValueFromEvent } from '../util/util';
Expand All @@ -20,12 +22,28 @@ import { claimAFacilityFormStyles } from '../util/styles';

import { claimAFacilityFormFields } from '../util/constants';

import { contributorOptionsPropType } from '../util/propTypes';

const {
companyName: companyFormField,
website: websiteFormField,
facilityDescription: descriptionFormField,
parentCompany: parentCompanyFormField,
} = claimAFacilityFormFields;

const selectStyles = Object.freeze({
input: provided =>
Object.freeze({
...provided,
padding: '10px',
}),
menu: provided =>
Object.freeze({
...provided,
zIndex: '2',
}),
});

function ClaimFacilityFacilityInfoStep({
companyName,
updateCompany,
Expand All @@ -34,6 +52,9 @@ function ClaimFacilityFacilityInfoStep({
facilityDescription,
updateDescription,
fetching,
contributorOptions,
parentCompany,
updateParentCompany,
}) {
return (
<>
Expand All @@ -55,6 +76,30 @@ function ClaimFacilityFacilityInfoStep({
disabled={fetching}
/>
</div>
{
contributorOptions && (
<div style={claimAFacilityFormStyles.inputGroupStyles}>
<InputLabel htmlFor={parentCompanyFormField.id}>
<Typography variant="title">
{parentCompanyFormField.label}
</Typography>
</InputLabel>
<aside style={claimAFacilityFormStyles.asideStyles}>
{parentCompanyFormField.aside}
</aside>
<div style={claimAFacilityFormStyles.textFieldStyles}>
<Select
options={contributorOptions}
id={parentCompanyFormField.id}
value={parentCompany}
onChange={updateParentCompany}
disabled={fetching}
styles={selectStyles}
/>
</div>
</div>
)
}
<div style={claimAFacilityFormStyles.inputGroupStyles}>
<InputLabel htmlFor={websiteFormField.id}>
<Typography variant="title">
Expand Down Expand Up @@ -91,6 +136,11 @@ function ClaimFacilityFacilityInfoStep({
);
}

ClaimFacilityFacilityInfoStep.defaultProps = {
contributorOptions: null,
parentCompany: null,
};

ClaimFacilityFacilityInfoStep.propTypes = {
companyName: string.isRequired,
website: string.isRequired,
Expand All @@ -99,28 +149,40 @@ ClaimFacilityFacilityInfoStep.propTypes = {
updateCompany: func.isRequired,
updateWebsite: func.isRequired,
updateDescription: func.isRequired,
contributorOptions: contributorOptionsPropType,
parentCompany: shape({
value: number.isRequired,
label: string.isRequired,
}),
updateParentCompany: func.isRequired,
};

function mapStateToProps({
claimFacility: {
claimData: {
formData: { companyName, website, facilityDescription },
formData: { companyName, website, facilityDescription, parentCompany },
fetching,
},
parentCompanyOptions: {
data: contributorOptions,
},
},
}) {
return {
companyName,
website,
facilityDescription,
fetching,
contributorOptions,
parentCompany,
};
}

function mapDispatchToProps(dispatch) {
return {
updateCompany: e =>
dispatch(updateClaimAFacilityCompany(getValueFromEvent(e))),
updateParentCompany: v => dispatch(updateClaimAFacilityParentCompany(v)),
updateWebsite: e =>
dispatch(updateClaimAFacilityWebsite(getValueFromEvent(e))),
updateDescription: e =>
Expand Down
14 changes: 14 additions & 0 deletions src/app/src/components/ClaimFacilityVerificationInfoStep.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,19 @@ const {
preferredContactMethod: preferredContactMethodFormField,
} = claimAFacilityFormFields;

const selectStyles = Object.freeze({
input: provided =>
Object.freeze({
...provided,
padding: '10px',
}),
menu: provided =>
Object.freeze({
...provided,
zIndex: '2',
}),
});

function ClaimFacilityVerificationInfoStep({
verificationMethod,
updateVerification,
Expand All @@ -50,6 +63,7 @@ function ClaimFacilityVerificationInfoStep({
value={preferredContactMethod}
onChange={updateContactPreference}
disabled={fetching}
styles={selectStyles}
/>
</div>
</div>
Expand Down