misc #391
Merged
misc #391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only "om <path> create" was allowed, which was confusing.
Fix the field paths of the data passed to template.Execute() in the "om node events --template ..." command.
Don't stale on prov and unprov orchestrations when the local instance is avail n/a. There is nothing we can do in this case, so set the mon state reached.
Use instance.Status.IsHALeader instead of instance.Status.IsLeader as instance.Status.IsHALeader is the one used by the start orchestration and by "om mon" to display the instance placement leader (the ^ symbol).
IsHALeader is the flag used by "om mon" and the start orchestration.
Remove a heading '#'. Rephrase.
Use a dedicated instance.Monitor.OrchestrationIsDone bool instead to determine all instances have finished their orchestration part without loosing the last state the orchestration might want to persist. Implement the failover after a switch attempt produced a "start failed" on the destination node.
The "changed" bool was left to false after deleting a section in-memory, so Commit() exited before writing the file.
Instead of the hardcoded "om3".
Example: $ om3 'fiz*' start 00000000-0000-0000-0000-000000000000 fiz1 400 set monitor: invalid instance monitor global expect: started: already started 1a93754a-e54a-4ca9-873a-9efe9a57500d fiz4
And document the change from v2
standby down: s => x
standby up: S => o
So endOrchestration is responsible for reseting it when all instances are done aborting.
Still expecting HALeader on a unprovisioned instance.
And factorize the done() code, by calling done() from doneAndIdle()
As it sets the .change
Except "aborted".
Object instance must exist. And limit the time we wait for SetObjectMonitor to reply on the err chan.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.