remaining nodes publish xxxDeleted message for peer removed or lost #393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…anyore a cluster node
…ll be done on detection like other nodes We don't need to drop peer node from daemon data in a synchronous call. event msgbus.ClusterConfigUpdated with removed nodes cluster can be used instead on all remaining cluster nodes TODO: drop peer on msgbus.ClusterConfigUpdated
…<peer>} TODO: update dropPeer to publish related deletion, and drop peer from instance and node data holders
…r.node.<node>.monitor
NodeMonitorDeleted is published when nmon ends (during daemon stop)
Deleting all d.clusterData.Cluster.Node[<node>] can panic daemondata commitPendingOps:
panic: nil d.clusterData.Cluster.Node[d.localNode].Status.Gen
goroutine 281 [running]:
github.com/opensvc/om3/daemon/daemondata.(*data).commitPendingOps(0xc004ed4280)
daemon/daemondata/apply_commit.go:36 +0x3ad
github.com/opensvc/om3/daemon/daemondata.(*data).run(0xc004ed4280, {0x2aa49b0, 0xc004ddb400}, 0xc004daff80, 0xc004ed8000, 0x2625a00)
daemon/daemondata/data.go:262 +0xbd7
github.com/opensvc/om3/daemon/daemondata.Start.func1()
daemon/daemondata/main.go:49 +0x70
created by github.com/opensvc/om3/daemon/daemondata.Start
daemon/daemondata/main.go:47 +0x19b
FAIL github.com/opensvc/om3/daemon/daemon 3.386s
Now ApplyMessage(NodeMonitorDeleted{Node:<node>}) will simply update cluster.node.<node>.monitor with state shutting:
=> cluster.node.<node>.monitor = {State: node.MonitorStateShutting, StateUpdatedAt: time.Now()}}
daemondata has the responsibility of peer data updates (has what is done during apply patch and apply full) On drop peer, daemondata must create and publish deleted object from dropped peer
…tance and node data holder databus.DropPeerNode(peer) does this This commits also update log when drop peer is called
…of msgbus.ForgetPeer Since daemondata drop peer publish msgbus.InstanceXXXDeleted messages we can use them to clean the local imon cache.
…of msgbus.ForgetPeer Since daemondata drop peer publish msgbus.InstanceXXXDeleted messages we can use them to clean the local omon cache.
…node reduce log level to info for messages: - forget removed peer %s => new live peers ... - forget <removed|lost> peer %s, we still have nodes quorum
… cluster node This should not happen
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.