daemon-subdaemon-removal #416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daemon components won't anymore embed *subdaemon.T
daemon components won't anymore embed *subdaemon.T
daemon components won't anymore embed *subdaemon.T t.Stop() now returns when internal waitGroup is done
daemon components won't anymore embed *subdaemon.T This commit also removes useless code: loop & httpHandler
daemon components won't anymore embed *subdaemon.T
DaemonApi has a new LabelNode member that is defined during api.RegisterHandlers => mocked hostname value during tests is applied to daemon api used label node
Previous implementation has unclear start/stop order. Now created routines that has its own stop methods will use main t.ctx context: - controller other routines will use a cancelable context, that is cancelled during t.Stop() - msgToTx - msgFromRx - janitor - hb drivers => Stop() 1- t.cancel() => cancel msgToTx, msgFromRx, janitor, hb drivers 2- stop started hb drivers 3- wait for wait group (msgToTx, msgFromRx and janitor are done) 4- stop the controller - msgToTx and msgFromRx returns when it detects cancellation while processing message
This stop the associated goroutine
## all components are now managed by the startStopper interface.
- hbcache
- ccfg
- cstat
- istat
## Stop function now waits for all components done before return.
## notifyWatchDog functions are now defined in dedicated functions:
- notifyWatchDogSys (for systemd watch dog)
- notifyWatchDogBus (for pubsub watch dog)
## use dedicated stopWatcher function to watch for daemon stop requests:
- stop from signal
- stop from msgbus.DaemonCtl
## update daemoncli to use Start from daemon instead of RunDaemon
WARNING: DATA RACE
Read at 0x00c004047ae0 by goroutine 91:
github.com/opensvc/om3/daemon/listener/lsnrhttpux.(*T).Stop()
.../om3/daemon/listener/lsnrhttpux/main.go:82 +0x19c
github.com/opensvc/om3/daemon/listener.startStopper·1.Stop-fm()
<autogenerated>:1 +0x48
github.com/opensvc/om3/daemon/listener.(*T).Stop()
.../om3/daemon/listener/main.go:111 +0x1c1
github.com/opensvc/om3/daemon/daemon.(*T).startComponent.func1()
.../om3/daemon/daemon/main.go:247 +0xba
github.com/opensvc/om3/daemon/daemon.(*T).Stop()
.../om3/daemon/daemon/main.go:165 +0x23a
github.com/opensvc/om3/daemon/daemon_test.TestDaemon.func2.2()
.../om3/daemon/daemon/main_test.go:57 +0x39
testing.tRunner()
/usr/local/go/src/testing/testing.go:1576 +0x216
testing.(*T).Run.func1()
/usr/local/go/src/testing/testing.go:1629 +0x47
Previous write at 0x00c004047ae0 by goroutine 50:
github.com/opensvc/om3/daemon/listener/lsnrhttpux.(*T).Start.func1()
.../om3/daemon/listener/lsnrhttpux/main.go:69 +0x6d1
github.com/opensvc/om3/daemon/listener/lsnrhttpux.(*T).Start.func2()
.../om3/daemon/listener/lsnrhttpux/main.go:74 +0x47
Goroutine 91 (running) created at:
testing.(*T).Run()
/usr/local/go/src/testing/testing.go:1629 +0x805
github.com/opensvc/om3/daemon/daemon_test.TestDaemon.func2()
.../om3/daemon/daemon/main_test.go:56 +0x259
testing.tRunner()
/usr/local/go/src/testing/testing.go:1576 +0x216
testing.(*T).Run.func1()
/usr/local/go/src/testing/testing.go:1629 +0x47
Goroutine 50 (running) created at:
github.com/opensvc/om3/daemon/listener/lsnrhttpux.(*T).Start()
.../om3/daemon/listener/lsnrhttpux/main.go:47 +0x204
github.com/opensvc/om3/daemon/listener.(*T).Start()
.../om3/daemon/listener/main.go:95 +0xd6c
github.com/opensvc/om3/daemon/daemon.(*T).startComponent()
.../om3/daemon/daemon/main.go:241 +0x72
github.com/opensvc/om3/daemon/daemon.(*T).Start()
.../om3/daemon/daemon/main.go:146 +0x136e
github.com/opensvc/om3/daemon/daemon_test.TestDaemon.func2.1()
.../om3/daemon/daemon/main_test.go:51 +0x58
testing.tRunner()
/usr/local/go/src/testing/testing.go:1576 +0x216
testing.(*T).Run.func1()
/usr/local/go/src/testing/testing.go:1629 +0x47
==================
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.