implement delete orchestration, change cli 'delete --rid xx' to 'unset --rid xx' #432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ailed Also implement helper: func (t MonitorState) Is(states ...MonitorState) bool
Without this commit we have to wait for expected orchestration (on next event that may call orchestrate)
…balExpectUpdated is changed
This prevents a global expect changed to be reset during:
orchestration done on node
orchestration is done on all nodes
INF main.go:399 > change monitor global expect none -> deleted func=imon object=obj
DBG om3/util/pubsub/main.go:483 > route publication obj@node1 down down thawed true [node1] with labels path=obj node=node1 to subscription 'daemondata' ...
INF main.go:407 > change monitor state start failed -> idle func=imon object=obj
DBG om3/util/pubsub/main.go:483 > route publication obj@node1 down down thawed true [node1] with labels path=obj node=node1 to subscription 'obj imon' ...
INF main.go:410 > change leader state false -> true func=imon object=obj
DBG om3/daemon/omon/main.go:390 > update avail down func=omon object=obj
INF main.go:413 > change ha leader state false -> true func=imon object=obj
DBG om3/util/pubsub/main.go:483 > route publication obj@node1 down down thawed true [node1] with labels path=obj node=node1 to subscription 'daemondata' ...
DBG om3/util/pubsub/main.go:483 > route publication obj@node1 down down thawed true [node1] with labels path=obj node=node1 to subscription 'obj imon' ...
DBG om3/util/pubsub/main.go:483 > route publication type *msgbus.InstanceMonitorUpdated with labels path=obj node=node1 to subscription 'waiting for delete, deleting' ...
DBG om3/util/pubsub/main.go:483 > route publication type *msgbus.InstanceMonitorUpdated with labels path=obj node=node1 to subscription 'obj omon' ...
DBG om3/util/pubsub/main.go:483 > route publication type *msgbus.InstanceMonitorUpdated with labels path=obj node=node1 to subscription 'daemondata' ...
DBG om3/daemon/omon/main.go:390 > update avail down func=omon object=obj
INF orchestration.go:187 > orchestration done on node node1: state:idle orchestrationId:66c8e677-31ed-429b-bd00-3f3f80773c43 func=imon object=obj
DBG om3/util/pubsub/main.go:483 > route publication obj@node1 down down thawed true [node1] with labels path=obj node=node1 to subscription 'daemondata' ...
INF orchestration.go:193 > orchestration is done on all nodes func=imon object=obj
DBG om3/util/pubsub/main.go:483 > route publication obj@node1 down down thawed true [node1] with labels path=obj node=node1 to subscription 'obj imon' ...
INF main.go:399 > change monitor global expect deleted -> none func=imon object=obj
cgalibern
changed the title
cgalibern
force-pushed
the
deleted_orchestration
branch
from
16fcd12
to
3ecc378
Compare
…sly delete)
The delete command is related to object or instance deletion only not anymore to object resource id.
The removal of some object sections is done by 'unset' command.
Example:
om foo unset --section fs#1
cgalibern
force-pushed
the
deleted_orchestration
branch
from
3ecc378
to
8bc9ff0
Compare
This commit removes 'om cluster delete' command': - cluster can't be deleted. - cluster config section are removed with unset command This commit prevents from unexpected cluster config deletion
The om node delete command is removed (unset can be used instead).
This commit implements node section removal with:
om node unset --section xxx
The om node delete command is removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.