Pass logger as a object.New() funcopt #434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Let the caller decide of the logger config, if any. This patch add a objectlogger package to make it easy for a object.New* caller to create a logger that satisfies the opensvc CRM expectations.
Now the test must allocate a objectlogger logger to get a log file. The default behaviour is now to not create a logs if not asked to do so.
Stop logging to our own log files. Start reworking the logs so the message includes the revelent key infos in a grammatically correct phrase. Because journalctl doesn't show keys by default, and adds many keys that don't help reading logs with keys.
Describes better what the value means.
* daemon: api * daemon: cmd * daemon: nmon * daemon: imon * daemon: ccfg * daemon: discover: fs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.