fix daemon crash on collector ping start/stop #462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…(fix) panic: runtime error: invalid memory address or nil pointer dereference [signal SIGSEGV: segmentation violation code=0x1 addr=0x10 pc=0xf0f0f0] goroutine 56 [running]: github.com/opensvc/om3/core/collector.(*Pinger).Stop(...) /home/runner/work/om3/om3/core/collector/rpc.go:86 github.com/opensvc/om3/daemon/collector.(*T).onConfigUpdated(0xc0040b01e0) /home/runner/work/om3/om3/daemon/collector/main.go:180 +0x110 github.com/opensvc/om3/daemon/collector.(*T).onClusterConfigUpdated(...) /home/runner/work/om3/om3/daemon/collector/main.go:167
The t.ctx was changed to nil during ping stop
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x20 pc=0xa52e74]
goroutine 2986 [running]:
github.com/opensvc/om3/core/collector.(*Pinger).Start.func1()
/root/dev/om3/core/collector/rpc.go:77 +0x114
created by github.com/opensvc/om3/core/collector.(*Pinger).Start in goroutine 1533
/root/dev/om3/core/collector/rpc.go:64 +0xab
panic: runtime error: invalid memory address or nil pointer dereference [signal SIGSEGV: segmentation violation code=0x1 addr=0x30 pc=0xae5a05] goroutine 102 [running]: github.com/opensvc/om3/core/collector.(*Pinger).Start.func1() /home/runner/work/om3/om3/core/collector/rpc.go:64 +0xa5 created by github.com/opensvc/om3/core/collector.(*Pinger).Start /home/runner/work/om3/om3/core/collector/rpc.go:62 +0xb4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.