Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(*): update nvmrc to 12 and updated gitignore #499

Merged
merged 6 commits into from Aug 26, 2020

Conversation

ronniechong
Copy link
Collaborator

@ronniechong ronniechong commented Aug 25, 2020

This PR is upgrading node version to 12 and add specificity to gitignore for scss, css modules and js files in OTKit and OTTheme. This allows the style-guide to use scss files without being omitted.

Travis will be running on node 12 as well

@ronniechong ronniechong self-assigned this Aug 25, 2020
@jakeclements jakeclements self-requested a review August 26, 2020 00:16
@jakeclements jakeclements merged commit 2c0bbcd into opentable:master Aug 26, 2020
@ronniechong ronniechong deleted the chore branch August 26, 2020 09:53
karuto pushed a commit to karuto/design-tokens that referenced this pull request Jun 15, 2022
* fix(docs): updates README

* build(*): update nvmrc to 12 and updated gitignore

* build(*): updates travis node version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants