Make Darwin bundle fully self-contained by including libpq #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
libpq is the C Postgres client library. It is used by bin/initdb which is
packaged and run by this project.
While the Linux and Windows tarballs contain libpq, the Mac (Darwin) one does
not. This mostly works out ok because Macs ship with /usr/lib/libpq.5.dylib (and
you can install your own libpq to other places like /usr/local/lib with, eg,
Homebrew), but this might be a surprising version or may be misinstalled. (I
discovered this problem when my Homebrew Postgres installation was misinstalled
and it broke EmbeddedPostgres.)
By packaging libpq with the Darwin bundle, EmbeddedPostgres can be fully
selfcontained on Mac.
You can verify this as follows:
./repack-postgres.sh
mkdir unpacked
cd unpacked
tar xJf ../target/generated-resources/postgresql-Darwin-x86_64.txz
DYLD_PRINT_LIBRARIES=YES ./bin/initdb --version 2>&1 | grep libpq
Before this change, the final command reads:
dyld: loaded: /usr/lib/libpq.5.dylib
After this change, it reads:
dyld: loaded: /private/tmp/otj-pg-embedded/unpacked/./bin/../lib/libpq.5.dylib
|
It looks like MacOS 11 (Big Sur) doesn't ship libpq.5.dylib. So it is not possible to use pg-embedded without libpq.5.dylib |
|
Yes. This PR is required for Big Sur. I've tested it in my environment and it works just fine. Thank you for link to zonkyio fork. I will check it. |
|
We are going the docker route, making this PR obsolete |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
libpq is the C Postgres client library. It is used by bin/initdb which is
packaged and run by this project.
While the Linux and Windows tarballs contain libpq, the Mac (Darwin) one does
not. This mostly works out ok because Macs ship with /usr/lib/libpq.5.dylib (and
you can install your own libpq to other places like /usr/local/lib with, eg,
Homebrew), but this might be a surprising version or may be misinstalled. (I
discovered this problem when my Homebrew Postgres installation was misinstalled
and it broke EmbeddedPostgres.)
By packaging libpq with the Darwin bundle, EmbeddedPostgres can be fully
self-contained on Mac.
You can verify this as follows:
Before this change, the final command reads:
After this change, it reads: