Add unit test triggering the issue

opentap · Apr 29, 2024 · e0e6276 · e0e6276
1 parent 8dc0adc
commit e0e6276
Show file tree

Hide file tree

Showing 2 changed files with 35 additions and 0 deletions.
diff --git a/Engine.UnitTests/ResultListeners/PlanRunCollectorListener.cs b/Engine.UnitTests/ResultListeners/PlanRunCollectorListener.cs
@@ -13,6 +13,8 @@ public class PlanRunCollectorListener : ResultListener
         public List<TestPlanRun> PlanRuns = new List<TestPlanRun>();
         [XmlIgnore]
         public List<TestStepRun> StepRuns = new List<TestStepRun>();
+        [XmlIgnore]
+        public List<TestStepRun> StepRunStartEvents = new List<TestStepRun>();
 
         public string LogString;
 
@@ -30,6 +32,7 @@ public override void OnTestPlanRunCompleted(TestPlanRun planRun, System.IO.Strea
 
         public override void OnTestStepRunStart(TestStepRun stepRun)
         {
+            StepRunStartEvents.Add(stepRun);
             base.OnTestStepRunStart(stepRun);
         }
 

diff --git a/Engine.UnitTests/Results2.cs b/Engine.UnitTests/Results2.cs
@@ -4,6 +4,7 @@
 using System.Threading;
 using System.Threading.Tasks;
 using NUnit.Framework;
+using OpenTap.Engine.UnitTests;
 using OpenTap.Plugins.BasicSteps;
 
 namespace OpenTap.UnitTests
@@ -125,5 +126,36 @@ public void TestSetParameterRaceCondition(int threadCount, int paramsPerThread)
                 Assert.AreEqual(param, i);
             }
         }
+
+        class ParameterAssigningResultListener : ResultListener
+        {
+            public List<string> Assignments = new List<string>();
+            public override void OnTestStepRunStart(TestStepRun stepRun)
+            {
+                base.OnTestStepRunStart(stepRun);
+                foreach (var assignment in Assignments)
+                {
+                    stepRun.Parameters[assignment] = assignment;
+                }
+            }
+        }
+
+        [Test]
+        public void TestRacyResultListeners()
+        {
+            using var session = Session.Create(SessionOptions.OverlayComponentSettings);
+            var collector = new PlanRunCollectorListener();
+            var a1 = new ParameterAssigningResultListener() { Assignments = { "Param1", "Param2", "Param3" } };
+            var a2 = new ParameterAssigningResultListener() { Assignments = { "Param4", "Param5", "Param6" } };
+            ResultSettings.Current.Add(a1);
+            ResultSettings.Current.Add(a2);
+            ResultSettings.Current.Add(collector);
+
+            var plan = new TestPlan();
+            plan.ChildTestSteps.Add(new DelayStep());
+            plan.Execute();
+
+            Assert.AreEqual(collector.StepRunStartEvents[0].Verdict, Verdict.NotSet);
+        }
     }
 }