1045 repo 4.0 #1087
Merged
1045 repo 4.0 #1087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alnlarsen
force-pushed
the
1045-repo-4.0
branch
from
89e66f7
to
0b3c451
Compare
alnlarsen
force-pushed
the
1045-repo-4.0
branch
from
0b3c451
to
db898e1
Compare
StefanHolst
requested changes
Apr 18, 2023
| @@ -439,6 +321,25 @@ public void DownloadPackage(IPackageIdentifier package, string destination, Canc | |||
| } | |||
| } | |||
|
|
|||
| private void Auth() | |||
There was a problem hiding this comment.
Should we call it something like, AttachAuthentication?
| PackageDef.SaveManyTo(stream, ConvertToPackageDef(compatibleWith)); | ||
| stream.Seek(0, 0); | ||
| string data = new StreamReader(stream).ReadToEnd(); | ||
| ["type"] = @class, |
There was a problem hiding this comment.
Type and class are not the same. It should just be class
AsgerIversen
approved these changes
Apr 20, 2023
|
This change is part of OpenTAP version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use repo client and target repo 4.0 API to support authentication
Closes #1045