Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1282-GetSettingsLookupRaceFix: Test #1283

Merged
merged 2 commits into from Oct 9, 2023
Merged

1282-GetSettingsLookupRaceFix: Test #1283

merged 2 commits into from Oct 9, 2023

Commits on Oct 9, 2023

  1. 1282-GetSettingsLookupRaceFix: Test 

    Added unit test to show the issue.
    @rmadsen-ks
    rmadsen-ks committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    8713924 View commit details
    Browse the repository at this point in the history

  2. 1282 Get Settings Lookup Race Fix: Fix 

    Fixed the issue by using ImmutableDictionary.SetItem instead of ImmutableDictionary.Add.

The difference is that SetItem updates values of existing keys while Add throws an exception if the key exists in the dictionary.
    @rmadsen-ks
    rmadsen-ks committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    913d99b View commit details
    Browse the repository at this point in the history