Determine if a relative url is an http repository by trying to connect to it #1606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t to it This fixes an issue that makes it impossible to use a local absolute path on Linux and Mac. Closes #1595
alnlarsen
force-pushed
the
1595-detect-repo-when-using-relative-urls
branch
from
61b3aaa
to
960af54
Compare
Denrask
approved these changes
Jun 27, 2024
|
@Denrask if an absolute path is used which is determined to be an http repository it will be used as a file repository (which will of course have no packages). You raise a good point. We have a lot of unit tests exercising this, but they don't use base address. We should test them all with and without a base address. |
alnlarsen
force-pushed
the
1595-detect-repo-when-using-relative-urls
branch
from
a7d58e8
to
e19163d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue that makes it impossible to use a local absolute path on Linux and Mac.
Closes #1595