Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Platform]: pharmgkb allele column #335

Merged
merged 3 commits into from
Feb 27, 2024
Merged

[Platform]: pharmgkb allele column #335

merged 3 commits into from
Feb 27, 2024

Conversation

chinmehta
Copy link
Contributor

@chinmehta chinmehta commented Feb 21, 2024

[Platform]: pharmgkb allele column

Description

Adding a new column containing link. If link id is null it will show without link, if show id is null it will display link id with link id text.

Issue: # opentargets/issues#3219
Deploy preview: https://deploy-preview-335--ot-platform.netlify.app/target/ENSG00000138109

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

  • Test A: go to pharmgkb and verify the star allele column

Checklist:

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@chinmehta chinmehta marked this pull request as ready for review February 27, 2024 11:21
@carcruz carcruz merged commit 81d6a96 into main Feb 27, 2024
11 checks passed
@carcruz carcruz deleted the cm-pharmgkb-allele branch February 27, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants