Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Genetics] Convert ScrollToTop component to TS #355

Merged
merged 2 commits into from
Apr 30, 2024
Merged

[Genetics] Convert ScrollToTop component to TS #355

merged 2 commits into from
Apr 30, 2024

Conversation

riyavsinha
Copy link
Contributor

Description

Simple refactor of ScrollToTop component to TS. only change needed was declaring the prop types as RouteComponentProps.

Issue: # 2871
Deploy preview: (link)

Type of change

  • TS Refactor

How Has This Been Tested?

  • Manual

Checklist:

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@carcruz carcruz merged commit d89f97d into opentargets:main Apr 30, 2024
6 checks passed
gjmcn pushed a commit that referenced this pull request May 7, 2024
@riyavsinha @gjmcn
[Genetics] Convert ScrollToTop component to TS (#355)
350195b 
* rename: src/components/ScrollToTop.jsx -> src/components/ScrollToTop.tsx

* refactor: convert scrolltotop to ts adding react-router prop types
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carcruz carcruz carcruz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@riyavsinha @carcruz