Made number of query terms validated below a configurable threshold #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
jdhayhurst
commented
Nov 23, 2023
jdhayhurst
commented
- part of API endpoint for verifying entity list for Upload target list issues#3114
- adding validator for number for query terms
- max number of query terms is configurable via environment variable, defaults to 2000
mbdebian
requested changes
Nov 23, 2023
There was a problem hiding this comment.
Thanks for the PR @jdhayhurst !
Would you mind having a look at the comment on the review request?
| @@ -65,6 +65,7 @@ object Configuration { | |||
| elasticsearch: ElasticsearchSettings, | |||
| clickhouse: ClickhouseSettings, | |||
| ignoreCache: Boolean, | |||
| maxNumberQueryTerms: Int, | |||
There was a problem hiding this comment.
We need to contextualise what this number refers to, in this case it is the number of query terms for the validation API, i.e. an example of naming would be qValidationLimitNTerms
There was a problem hiding this comment.
renamed with your suggestion
mbdebian
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.