Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix openfda output header #1195

Closed
cmalangone opened this issue Sep 7, 2020 · 1 comment
Closed

Fix openfda output header #1195

cmalangone opened this issue Sep 7, 2020 · 1 comment
Assignees

Comments

@cmalangone
Copy link

Fix the openfda output header to:

CSV/JSON
chembl_id,event,count,llr,critval

Add in the README file the way that the output are used in the OT project.

CSV: adverse_event in the current pipeline
JSON: openfda index in the ETL pipeline

Thanks

@mkarmona
Copy link
Contributor

mkarmona commented Sep 7, 2020

@cmalangone @JarrodBaker whether it better fits you, people. Although, the changes should, at least, reduce the number of name transformations they have from start to end. If we need to change names let's do it all at once. I would suggest following camel case when in doubt or situations like this. We would start applying this way consistently and strictly (myself included! mea culpa as I started this mess time ago when I coded OpenFDA pipeline).

mkarmona added a commit to opentargets/platform-etl-openfda-faers that referenced this issue Sep 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants