Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No target tractability data notification not always visible #783

Closed
andrewhercules opened this issue Nov 21, 2019 · 1 comment
Closed

No target tractability data notification not always visible #783

andrewhercules opened this issue Nov 21, 2019 · 1 comment
Assignees
Labels
Bug Something isn't working

Comments

@andrewhercules
Copy link
Contributor

@PruMM has identified an issue where the sentence about no tractability data is not visible for some targets. For a target like TRIP11, we display the sentence No tractability data for TRIP11 is available in the Target Tractability section:

Screenshot 2019-11-21 at 10 43 20

However, for a target like BRCA2, the sentence about no tractability data does not show:

Screenshot 2019-11-21 at 10 41 32

In reviewing the API response for both targets, the BRCA2 API response has an empty object for tractability compared to the API response for TRIP11 which has the full tractability schema but no data in the respective buckets fields.

@LucaFumis, can we please update the logic in the target-tractability.html file to check if the tractability key is an empty object { } in addition to both arrays being empty?

@AsierGonzalez
Copy link

The real cause of this issue is that TRIP11 (ENSG00000100815) appears in the tractability file whereas BRCA2 (ENSG00000139618) doesn't, is this expected? My understanding was that the tractability pipeline was supposed to generate an entry for all the genes regardless of whether they are tractable or not.

LucaFumis added a commit to opentargets-archive/webapp that referenced this issue Nov 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants